Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161110AbWBNVDe (ORCPT ); Tue, 14 Feb 2006 16:03:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161111AbWBNVDe (ORCPT ); Tue, 14 Feb 2006 16:03:34 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:19475 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1161110AbWBNVDd (ORCPT ); Tue, 14 Feb 2006 16:03:33 -0500 Date: Tue, 14 Feb 2006 21:03:24 +0000 From: Russell King To: Takashi Iwai Cc: Mark Lord , "linux-os (Dick Johnson)" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add cast to __iomem pointer in scsi drivers Message-ID: <20060214210324.GA13442@flint.arm.linux.org.uk> Mail-Followup-To: Takashi Iwai , Mark Lord , "linux-os (Dick Johnson)" , Andrew Morton , linux-kernel@vger.kernel.org References: <43F2419E.9060308@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 16 On Tue, Feb 14, 2006 at 09:59:05PM +0100, Takashi Iwai wrote: > Yes, that'll be the best solution. But, in these drivers, the same > struct fields are used for both inl() and writel() depending on the > flag, so you cannot change the type. Which is why we have io{read|write}[bwl], iomap_port, etc. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/