Date: Tue, 14 Feb 2006 22:03:13 +0100
From: Jean Delvare <khali@linux-fr.org>
To: Herbert Poetzl <herbert@13thfloor.at>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove duplicate #includes
Message-Id: <20060214220313.1158be5b.khali@linux-fr.org>
In-Reply-To: <20060213093959.GA10496@MAIL.13thfloor.at>
References: <20060213093959.GA10496@MAIL.13thfloor.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1306
Lines: 33

Hi Herbert,

> recently I stumbled over a few files which #include the 
> same .h file twice -- sometimes even in the immediately
> following line. so I thought I'd look into that to reduce 
> the amount of duplicate includes in the kernel ...
> (...)
> diff -NurpP --minimal linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c
> --- linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c	2006-02-07 11:52:31 +0100
> +++ linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c	2006-02-13 02:07:58 +0100
> @@ -104,7 +104,6 @@
>  #include <linux/kernel.h>
>  #include <linux/delay.h>
>  #include <linux/sched.h>
> -#include <linux/i2c.h>
>  #include <linux/slab.h>
>  #include <linux/init.h>
>  #include <linux/spinlock.h>

This one was already taken care of in a different patch:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc3/2.6.16-rc3-mm1/broken-out/macintosh-cleanup-the-use-of-i2c-headers.patch

So please exclude this part from your patch so as to avoid collisions.

Thanks,
-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/