Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4206381ybf; Tue, 3 Mar 2020 22:50:08 -0800 (PST) X-Google-Smtp-Source: ADFU+vvFx1EfLQReAY3gDkgmjmsR5tW63l3yZiDGrpeuiOpN3bwLiJ9uZATIF1QbBABBverozPnz X-Received: by 2002:a05:6830:1b6e:: with SMTP id d14mr1237957ote.117.1583304608118; Tue, 03 Mar 2020 22:50:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583304608; cv=none; d=google.com; s=arc-20160816; b=iHlp0bWHGhPETXrXzX/I/5enlYKgs+iyFPwJ2ghYuMrMemyCP9u0dfFxEqG/cHt1Vn qzrxEM8rmyZwzmFTNjusa5yzDr4QNcDuw5jXDsCcr1ER2yGzI2CShuYnyVT68wlZ/7x0 s183NZEC7o1uz4dK/xrXAT/s4M6fwaT8c0iRTCmi2La/uI5XokF3Tqb21KNJ5FAkxglZ RAsQbujsnEZLfq/JkuTnNswI2rtwB0Ya3/Rk+g3+FEunXG0yuaJ7uCgFkafObItxmMnf 6RMbktJKESccDwjv1M/7Y9Ez/K56TkZlHOdq+r8yKdxoURDV2W7krFEC+ZUus+30lMMf wC4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=9rF2gDxcJYG5FSQ65aozmEbfjYLZaXTsO1ksbloV6x4=; b=b8W5ajLsen0hQYhKMHlQ+Zys3Umw1qXhjABHTK5vJTG2qPP4Kqcsu02/pHJ5vs6ZYi XGwB0jop08rQXyJdsQ2kEnTFhtFY9c8UZEfZtlltnozIMPh1GgiEVPS2NHcwRAOaUqlZ q0hcF+zbW8od0nlh4f6GRrl6ocdd4wCPHsbTSdECYIbnU2lM90YgP3oI8Y1sxECPYdbc NAkg5CiDTIvc8pgMNMTxADh7C0RUVTEi6KKeuJW4iV7Ta3BFtcY75Zf+Zipwn7epoIzE F862xvOZZpbdm1kU9ObLGYffu/Z+MiJhIHweD2WDxlbC7NXBSq82UGfPuAhr0i8stPw/ LlFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=V+kwW6Kv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d196si701278oig.268.2020.03.03.22.49.56; Tue, 03 Mar 2020 22:50:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=V+kwW6Kv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727734AbgCDGtq (ORCPT + 99 others); Wed, 4 Mar 2020 01:49:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:56654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725271AbgCDGtp (ORCPT ); Wed, 4 Mar 2020 01:49:45 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBE3E2146E; Wed, 4 Mar 2020 06:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583304585; bh=VK53u2VxkYUENGgHTPFGpT3Z/fpLjjPmXcKQ3gcUtws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+kwW6KvpMnnUi3CM3rOFD+6kThqvnEFjb1p+czVRydBv93/KSXzGe2IYFoW676Fv pH2x4cytTMjT9gRUPVeCMQ+P04yFBpP+CZWgtITnnRIko9PnsJXb6Tw5ZE2IyElK15 1/ziS9d0t+rBiXatxi4PMTLBHTJDG2uW3BZ39/MI= Date: Wed, 4 Mar 2020 07:49:43 +0100 From: Greg Kroah-Hartman To: Kaaira Gupta Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: qlge: emit debug and dump at same level Message-ID: <20200304064943.GA1232764@kroah.com> References: <20200224082448.GA6826@kaaira-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224082448.GA6826@kaaira-HP-Pavilion-Notebook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 01:54:48PM +0530, Kaaira Gupta wrote: > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > instead of existing functions so that the debug and dump are > emitted at the same KERN_ > > Signed-off-by: Kaaira Gupta > --- > > changes since v1: make code of ql_mpi_core_to_log() simpler. > changes since v2: directly call the function instead of defining a > macro. > changes since v3: Remove prefix string. > > ---- > --- > drivers/staging/qlge/qlge_dbg.c | 23 +++-------------------- > 1 file changed, 3 insertions(+), 20 deletions(-) Does not apply to my tree :(