Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <4e26c715b81fdea7d10e19ca46ffd2645cbe78f9.camel@intel.com>
Subject: Re: [PATCH] iwlwifi: pcie: restore support for Killer Qu C0 NICs
From:   Luciano Coelho <luciano.coelho@intel.com>
To:     Kalle Valo <kvalo@codeaurora.org>,
        "Jan Alexander Steffens (heftig)" <jan.steffens@gmail.com>
Cc:     Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 04 Mar 2020 09:10:24 +0200
In-Reply-To: <20200303152925.6BCA8C4479F@smtp.codeaurora.org>
References: <20191224051639.6904-1-jan.steffens@gmail.com>
         <20200303152925.6BCA8C4479F@smtp.codeaurora.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.1-4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-03-03 at 15:29 +0000, Kalle Valo wrote:
> "Jan Alexander Steffens (heftig)" <jan.steffens@gmail.com> wrote:
> 
> > Commit 809805a820c6 ("iwlwifi: pcie: move some cfg mangling from
> > trans_pcie_alloc to probe") refactored the cfg mangling. Unfortunately,
> > in this process the lines which picked the right cfg for Killer Qu C0
> > NICs after C0 detection were lost. These lines were added by commit
> > b9500577d361 ("iwlwifi: pcie: handle switching killer Qu B0 NICs to
> > C0").
> > 
> > I suspect this is more of the "merge damage" which commit 7cded5658329
> > ("iwlwifi: pcie: fix merge damage on making QnJ exclusive") talks about.
> > 
> > Restore the missing lines so the driver loads the right firmware for
> > these NICs.
> > 
> > Fixes: 809805a820c6 ("iwlwifi: pcie: move some cfg mangling from trans_pcie_alloc to probe")
> > Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
> 
> As Luca said, this fails to apply to wireless-drivers. Please rebase and
> resend as v2.

Hmmm, sorry, I confused things a bit.  I missed the fact that wireless-
drivers is already at v5.6.

This patch is not needed in v5.6-rc* because another patch has done a
similar change.  There was some refactoring in this area, so the patch
that is in v5.6 doesn't apply in v5.5, so Jan's patch has to be sent to
stable v5.5 and not be applied in wireless-drivers.

Jan, if you want this to be fixed in v5.5, can you please send it to 
stable@vger.kernel.org with an explanation of why it has to be there
even though it's not in the mainline? Or just send it and CC me, so
I'll reply with an explanation of the issue.

--
Cheers,
Luca.