Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422724AbWBNVO3 (ORCPT ); Tue, 14 Feb 2006 16:14:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422725AbWBNVO3 (ORCPT ); Tue, 14 Feb 2006 16:14:29 -0500 Received: from cantor.suse.de ([195.135.220.2]:11913 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1422724AbWBNVO2 (ORCPT ); Tue, 14 Feb 2006 16:14:28 -0500 Date: Tue, 14 Feb 2006 22:14:27 +0100 Message-ID: From: Takashi Iwai To: Al Viro Cc: Mark Lord , "linux-os (Dick Johnson)" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add cast to __iomem pointer in scsi drivers In-Reply-To: <20060214210538.GF27946@ftp.linux.org.uk> References: <43F2419E.9060308@rtr.ca> <20060214210538.GF27946@ftp.linux.org.uk> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta21) (corn) (+CVS-20050720) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 25 At Tue, 14 Feb 2006 21:05:38 +0000, Al Viro wrote: > > On Tue, Feb 14, 2006 at 09:59:05PM +0100, Takashi Iwai wrote: > > Yes, that'll be the best solution. But, in these drivers, the same > > struct fields are used for both inl() and writel() depending on the > > flag, so you cannot change the type. > > > > Hm, looks like I hit a dreadful case without a good solution. > > ioread*/iowrite* Ah, that's it. Thanks. So, the right fix is to rewrite struct ata_ioport to use iomem pointers and all accessses to ioread*/iowrite*() ? OK, it's a longer way to go :) Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/