Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422725AbWBNVRs (ORCPT ); Tue, 14 Feb 2006 16:17:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422733AbWBNVRs (ORCPT ); Tue, 14 Feb 2006 16:17:48 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:33690 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1422725AbWBNVRr (ORCPT ); Tue, 14 Feb 2006 16:17:47 -0500 Date: Tue, 14 Feb 2006 21:17:45 +0000 From: Al Viro To: Takashi Iwai Cc: Mark Lord , "linux-os (Dick Johnson)" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add cast to __iomem pointer in scsi drivers Message-ID: <20060214211745.GG27946@ftp.linux.org.uk> References: <43F2419E.9060308@rtr.ca> <20060214210538.GF27946@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 25 On Tue, Feb 14, 2006 at 10:14:27PM +0100, Takashi Iwai wrote: > At Tue, 14 Feb 2006 21:05:38 +0000, > Al Viro wrote: > > > > On Tue, Feb 14, 2006 at 09:59:05PM +0100, Takashi Iwai wrote: > > > Yes, that'll be the best solution. But, in these drivers, the same > > > struct fields are used for both inl() and writel() depending on the > > > flag, so you cannot change the type. > > > > > > Hm, looks like I hit a dreadful case without a good solution. > > > > ioread*/iowrite* > > Ah, that's it. Thanks. > > So, the right fix is to rewrite struct ata_ioport to use iomem > pointers and all accessses to ioread*/iowrite*() ? > OK, it's a longer way to go :) Jeff has that partially done... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/