Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4256223ybf; Wed, 4 Mar 2020 00:04:08 -0800 (PST) X-Google-Smtp-Source: ADFU+vsxeDZWZErBL876linGe6IlFjen6L2Adv6ZqIIZYF9bi3xCuZ+b63ra6/FuM0OWCWyvnP4N X-Received: by 2002:aca:3542:: with SMTP id c63mr916956oia.135.1583309048579; Wed, 04 Mar 2020 00:04:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583309048; cv=none; d=google.com; s=arc-20160816; b=mN6nPjmtbO9ESN+L9ySt4NLULpxRKNzzODtYnA3TtUwsr0s+j0QJEBfDhN9qXW/+mC oIQhxOtxpKKi0R8K41yelPw3mnWCA45XO2h6cloSmf3dnNGZ21ZiVCZV5trAjR0JPTZc uw/6Hc5zPfDAnGjiziNuDu3p1h74TnOB7uKE81nFdG7eeS1Fe1tbD5UcbveHPOU6PlUG rnYfNQtvngInuQTmyrQjTs1vWFQ43tgkNpr88dNXB57bY5CACInlBEo9q5dfRC9xA9Nj 8emw0uVvSVsuxkJL+akQwv7PDjfTPPe+5hYb8eU+LQdvHvjiiormPW4xwSjfSO3cIge+ e7kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fvcgS0kaXJOVRywfNG/lNV2uF4vbt2syEwAD5+QBlzo=; b=rfz60jCO0SiUa/y1vNm16jjNUrSUwFTff4avHrY33vWgdiByitYqHHFDY80kwFtK+6 kWZ+k8eglATTWcaY1+pHZ4uQgpmDdSCH5wtqKKX7BCIOm7jslFXJcL2cjBVlTiL/04gu alYocgt+o0d0KZyBH/G7+zjFybFOtIvbzfvNol9C0m/xcLGHwG6b21yNrvAVE86AZl5U mGha1RGiiINPlmj/8fvl0rtGIzUyk35i1XsRR47xLVN2fYgMSdIm3yNK06MdRDXLofqK 5IkaD+6f7ds8px30DrThpIK+LDb+OUTFYUHcZVaPKLU/YTKUBlacM5NWpFd+s3dm9/mG DmlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Gt4O3kKN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f137si725995oig.87.2020.03.04.00.03.57; Wed, 04 Mar 2020 00:04:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Gt4O3kKN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbgCDIDj (ORCPT + 99 others); Wed, 4 Mar 2020 03:03:39 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:42421 "EHLO mail-qv1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbgCDIDj (ORCPT ); Wed, 4 Mar 2020 03:03:39 -0500 Received: by mail-qv1-f42.google.com with SMTP id e7so391444qvy.9 for ; Wed, 04 Mar 2020 00:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fvcgS0kaXJOVRywfNG/lNV2uF4vbt2syEwAD5+QBlzo=; b=Gt4O3kKNzok2CysVWD2u3PBvZtBIGkUhLJORObJgQFPs1Y7YFnfuyfGf0IfBx8ZQ6b p9HsmW9q9BNbFTFVIf5K3vLxwkMJKJJmbc0OUO9Zk2BhG7rz0Pdev1f0YCblgQwmOGXf MmD2PpAwnKc1pJra4Wq+VUWyK0UaiWPrLNw+qhxbUC7RlFqjGAZcH1OabQg6Dx14jUJ6 QL0PoSg4O2TR3vtJdT8kEkFUrjUf+SFq4KeZ13AEAqtKK0idqq8MMAcrDUhoDZzqRVnh soPslGD1sOK53cGMv1QR9ngzipDeIgchY6Vpfd9Q7s2S+YAnBgUhcIeKxxdp5Bwh+ATi Tbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fvcgS0kaXJOVRywfNG/lNV2uF4vbt2syEwAD5+QBlzo=; b=gexu0XCD/dkXiYPLfx5DInVJIv6suYpKl1TxhdZQmA04FVPddvL8D7UTntX6L//Zwp jQsddeE5ywYdWwkfZ+yb+Wr13gJdIf2xiQag73Nbrs9BngcxFHLB30gM2uVJ5t9oTDdl HUi7ZKtqBov7LhtCmnZCxdD8hmdV3mvisS+q/Tw0Xe7wBOknE+eo4Vl7mNoQE5xXEwOu rtjl1TZ/FaqH7190Yi/yuUFpRZhxGpIuQw5yd03rreh+VyXTphLOOS3FnrMWZXp4udZo eufbD1VgXDFcjqOCtluiTo6LmBcxDUdD9iY6HFTUX2KDHiJL8UAcYxvuqjhcQIU6N+wX jZSw== X-Gm-Message-State: ANhLgQ1Jq/iPDV3b4J/hJ6PeaPkXB6JJejbtHhd+c+tj8S3bcVb3FL5h dj+psEI1krVTOUCPFfMTvEoIftSJVVHfmrsGQ8iEBQ== X-Received: by 2002:a05:6214:1467:: with SMTP id c7mr1167140qvy.122.1583309016750; Wed, 04 Mar 2020 00:03:36 -0800 (PST) MIME-Version: 1.0 References: <0000000000007523a60576e80a47@google.com> <20180928070042.GF3439@hirez.programming.kicks-ass.net> In-Reply-To: From: Dmitry Vyukov Date: Wed, 4 Mar 2020 09:03:25 +0100 Message-ID: Subject: Re: BUG: MAX_LOCKDEP_CHAINS too low! To: Cong Wang Cc: Taehee Yoo , Peter Zijlstra , syzbot , Ingo Molnar , Will Deacon , LKML , syzkaller-bugs , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 18, 2020 at 9:41 PM Cong Wang wrote: > > On Thu, Jan 16, 2020 at 7:09 AM Taehee Yoo wrote: > > Yes, I fully agree with this. > > If we calculate the subclass for lock_nested() very well, I think we > > might use static lockdep key for addr_list_lock_key too. I think > > "dev->upper_level" and "dev->lower_level" might be used as subclass. > > These values are updated recursively in master/nomaster operation. > > Great! I will think about this too. At least I will remove the other keys > for net-next. Hi Cong, Was this done? This still harms testing of the whole kernel. Disabling LOCKDEP does not look good either...