Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422789AbWBNVWt (ORCPT ); Tue, 14 Feb 2006 16:22:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422795AbWBNVWt (ORCPT ); Tue, 14 Feb 2006 16:22:49 -0500 Received: from smtp.osdl.org ([65.172.181.4]:29369 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1422789AbWBNVWs (ORCPT ); Tue, 14 Feb 2006 16:22:48 -0500 Date: Tue, 14 Feb 2006 13:21:33 -0800 From: Andrew Morton To: Jean Delvare Cc: herbert@13thfloor.at, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remove duplicate #includes Message-Id: <20060214132133.0c48f874.akpm@osdl.org> In-Reply-To: <20060214220313.1158be5b.khali@linux-fr.org> References: <20060213093959.GA10496@MAIL.13thfloor.at> <20060214220313.1158be5b.khali@linux-fr.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1704 Lines: 39 Jean Delvare wrote: > > Hi Herbert, > > > recently I stumbled over a few files which #include the > > same .h file twice -- sometimes even in the immediately > > following line. so I thought I'd look into that to reduce > > the amount of duplicate includes in the kernel ... > > (...) > > diff -NurpP --minimal linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c > > --- linux-2.6.16-rc2/drivers/macintosh/therm_pm72.c 2006-02-07 11:52:31 +0100 > > +++ linux-2.6.16-rc2-mpf/drivers/macintosh/therm_pm72.c 2006-02-13 02:07:58 +0100 > > @@ -104,7 +104,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > This one was already taken care of in a different patch: > > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc3/2.6.16-rc3-mm1/broken-out/macintosh-cleanup-the-use-of-i2c-headers.patch > > So please exclude this part from your patch so as to avoid collisions. > Is OK. I'll stage the big cleanup patches like this after everyone else's patches, so all that is left in this patch is stuff which doesn't intersect with anyone else's work. That's one of the advantages of having everyone's development trees all in one place. (And people who run development trees which aren't in -mm lose). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/