Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422812AbWBNVqk (ORCPT ); Tue, 14 Feb 2006 16:46:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422813AbWBNVqk (ORCPT ); Tue, 14 Feb 2006 16:46:40 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:8597 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1422812AbWBNVqj (ORCPT ); Tue, 14 Feb 2006 16:46:39 -0500 Subject: Re: [PATCH] tty reference count fix From: Arjan van de Ven To: Jason Baron Cc: Paul Fulghum , Andrew Morton , Linux Kernel Mailing List , "jesper.juhl@gmail.com" , Alan Cox In-Reply-To: References: <1139861610.3573.24.camel@amdx2.microgate.com> Content-Type: text/plain Date: Tue, 14 Feb 2006 22:46:29 +0100 Message-Id: <1139953590.4117.23.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 17 > > patch looks good to me. Or you could even drop the tty_sem completely from > the release_dev path (patch below) since lock_kernel() is held in both > tty_open() and the release_dev paths() (and there is no sleeping b/w > setting the tty_closing flag and setting the TTY_CLOSING bit). that's the wrong direction.. the idea is to first put new locking under the BKL layer.. and at the end pull the BKL entirely.. The BKL isn't a good lock. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/