Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Mar 2020 11:04:38 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     hpa@zytor.com
Cc:     Alexey Dobriyan <adobriyan@gmail.com>, rjw@rjwysocki.net,
        lenb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, luto@kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86/acpi: make "asmlinkage" part first thing in the
 function definition
Message-ID: <20200304100437.GM2596@hirez.programming.kicks-ass.net>
References: <20200303204144.GA9913@avx2>
 <9947D7CB-B9CD-47E0-BC5E-C7FC3A81FC7B@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9947D7CB-B9CD-47E0-BC5E-C7FC3A81FC7B@zytor.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 04, 2020 at 12:54:09AM -0800, hpa@zytor.com wrote:
> On March 3, 2020 12:41:44 PM PST, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >g++ insists that function declaration must start with extern "C"
> >(which asmlinkage expands to).
> >
> >gcc doesn't care.
> >
> >Signed-off-by: _Z6Alexeyv <adobriyan@gmail.com>
> >---
> >
> > arch/x86/kernel/acpi/sleep.c |    2 +-
> > arch/x86/kernel/acpi/sleep.h |    2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >--- a/arch/x86/kernel/acpi/sleep.c
> >+++ b/arch/x86/kernel/acpi/sleep.c
> >@@ -43,7 +43,7 @@ unsigned long acpi_get_wakeup_address(void)
> >  *
> >  * Wrapper around acpi_enter_sleep_state() to be called by assmebly.
> >  */
> >-acpi_status asmlinkage __visible x86_acpi_enter_sleep_state(u8 state)
> >+asmlinkage acpi_status __visible x86_acpi_enter_sleep_state(u8 state)
> > {
> > 	return acpi_enter_sleep_state(state);
> > }
> >--- a/arch/x86/kernel/acpi/sleep.h
> >+++ b/arch/x86/kernel/acpi/sleep.h
> >@@ -19,4 +19,4 @@ extern void do_suspend_lowlevel(void);
> > 
> > extern int x86_acpi_suspend_lowlevel(void);
> > 
> >-acpi_status asmlinkage x86_acpi_enter_sleep_state(u8 state);
> >+asmlinkage acpi_status x86_acpi_enter_sleep_state(u8 state);
> 
> Are you building the kernel with C++?!

He is :-) IIRC he's got a whole bunch of patches that removes all the
C++ keywords from the kernel.