Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Mar 2020 10:39:50 +0000
From:   Andre Przywara <andre.przywara@arm.com>
To:     Eric Auger <eric.auger@redhat.com>
Cc:     eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, alex.williamson@redhat.com,
        stable@vger.kernel.org, cohuck@redhat.com
Subject: Re: [PATCH] vfio: platform: Switch to platform_get_irq_optional()
Message-ID: <20200304103950.4e98d0ff@donnerap.cambridge.arm.com>
In-Reply-To: <20200302203715.13889-1-eric.auger@redhat.com>
References: <20200302203715.13889-1-eric.auger@redhat.com>
Organization: ARM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon,  2 Mar 2020 21:37:15 +0100
Eric Auger <eric.auger@redhat.com> wrote:

> Since commit 7723f4c5ecdb ("driver core: platform: Add an error
> message to platform_get_irq*()"), platform_get_irq() calls dev_err()
> on an error. As we enumerate all interrupts until platform_get_irq()
> fails, we now systematically get a message such as:
> "vfio-platform fff51000.ethernet: IRQ index 3 not found" which is
> a false positive.
> 
> Let's use platform_get_irq_optional() instead.

Yes, that seems correct to me and avoids the false positive error message I saw before.
 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Cc: stable@vger.kernel.org # v5.3+

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>

Thanks!
Andre

> ---
>  drivers/vfio/platform/vfio_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/vfio_platform.c b/drivers/vfio/platform/vfio_platform.c
> index ae1a5eb98620..1e2769010089 100644
> --- a/drivers/vfio/platform/vfio_platform.c
> +++ b/drivers/vfio/platform/vfio_platform.c
> @@ -44,7 +44,7 @@ static int get_platform_irq(struct vfio_platform_device *vdev, int i)
>  {
>  	struct platform_device *pdev = (struct platform_device *) vdev->opaque;
>  
> -	return platform_get_irq(pdev, i);
> +	return platform_get_irq_optional(pdev, i);
>  }
>  
>  static int vfio_platform_probe(struct platform_device *pdev)