Date: Wed, 15 Feb 2006 00:10:25 +0200
From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: Roland Dreier <rolandd@cisco.com>, gregkh@suse.de,
       linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: AMD 8131 and MSI quirk
Message-ID: <20060214221025.GB14329@mellanox.co.il>
Reply-To: "Michael S. Tsirkin" <mst@mellanox.co.il>
References: <524q799p2t.fsf@cisco.com> <20060214165222.GC12974@mellanox.co.il> <1139940226.18044.3.camel@whizzy> <20060214212145.GC14113@mellanox.co.il> <1139954779.26803.3.camel@whizzy>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1139954779.26803.3.camel@whizzy>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1120
Lines: 30

Quoting r. Kristen Accardi <kristen.c.accardi@intel.com>:
> I guess the assumption I made was that if msi is
> turned off for a bridge, then all devices under the bridge may not use
> msi.   

Well, all this is just quirks, so no real rules apply, thats why I thought
having 2 bits gives us maximum flexibility.

Specifically for PCXH I see this in code:
/*
 * It's possible for the MSI to get corrupted if shpc and acpi
 * are used together on certain PXH-based systems.
 * */

So it seems the issue is device-specific - only affects the bridge itself.

What the code currently does is disable msi for bridge itself but not for
the devices behind it. I cant inherit dev->no_msi from parent to child
without changing this, and I just assumed this is by design.

Are you saying this is a bug and should be changed?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/