Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 04 Mar 2020 14:07:17 +0300
From:   Cengiz Can <cengiz@kernel.wtf>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Jens Axboe <axboe@kernel.dk>, Ingo Molnar <mingo@redhat.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blktrace: fix dereference after null check
In-Reply-To: <20200303091436.2e7ab191@gandalf.local.home>
References: <20200303073358.57799-1-cengiz@kernel.wtf>
 <20200303091436.2e7ab191@gandalf.local.home>
Message-ID: <950cfb6c63a0ab33ff2b4bb33cfa3567@kernel.wtf>
User-Agent: Roundcube Webmail/1.3.8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-03-03 17:14, Steven Rostedt wrote:
> 
> Note, you should probably add a note in your change log that this issue 
> was
> found by Coverity. Sometimes static analyzers have a tag of some kind 
> that
> they would like patches that fix the issues they discover to be in the
> change log. This way they can track the fixes that are found by the 
> tool.
> 

I have added the Coverity issue ID and relevant notes to mark it. 
Thanks.

> 
> As I said in the other email, the above assignment still needs RCU
> annotation:
> 
> 		bt = rcu_dereference_protected(q->blk_trace,
> 				lockdep_is_held(&q->blk_trace_mutex));

I missed that. Thanks for reminding. TIL.

Please check PATCH-v2.

-- 
Cengiz Can
@cengiz_io