Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Mar 2020 12:55:46 +0100
From:   Andreas Klinger <ak@it-klinger.de>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
        pmeerw@pmeerw.net, Jonathan.Cameron@huawei.com,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] iio: ping: set pa_laser_ping_cfg in of_ping_match
Message-ID: <20200304115546.GA8509@arbad>
References: <20200304113423.26920-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <20200304113423.26920-1-yuehaibing@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Acked-by: Andreas Klinger <ak@it-klinger.de>

YueHaibing <yuehaibing@huawei.com> schrieb am Mi, 04. Mär 19:34:
> pa_laser_ping_cfg should be set in of_ping_match
> instead of pa_ping_cfg.
> 
> Fixes: 7bb501f49ddb ("iio: ping: add parallax ping sensors")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/iio/proximity/ping.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/proximity/ping.c b/drivers/iio/proximity/ping.c
> index 34aff10..12b893c 100644
> --- a/drivers/iio/proximity/ping.c
> +++ b/drivers/iio/proximity/ping.c
> @@ -269,7 +269,7 @@ static const struct iio_chan_spec ping_chan_spec[] = {
>  
>  static const struct of_device_id of_ping_match[] = {
>  	{ .compatible = "parallax,ping", .data = &pa_ping_cfg},
> -	{ .compatible = "parallax,laserping", .data = &pa_ping_cfg},
> +	{ .compatible = "parallax,laserping", .data = &pa_laser_ping_cfg},
>  	{},
>  };
>  
> -- 
> 2.7.4
> 
>