Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authenticated-By: 
From:   Hau <hau@realtek.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
CC:     Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Linux Netdev List <netdev@vger.kernel.org>,
        Kernel development list <linux-kernel@vger.kernel.org>,
        Anthony Wong <anthony.wong@canonical.com>,
        Jason Yen <jason.yen@canonical.com>
Subject: RE: SFP+ support for 8168fp/8117
Thread-Topic: SFP+ support for 8168fp/8117
Thread-Index: AQHVwTo87C9FPgb4q0K7N9j/9Mzg+6fW+ByAgAAXwwCAAE15gIAAfZ0AgECGEQCAAkeigIAECCeAgAQrRCCADDcng4AJ2WCQ
Date:   Wed, 4 Mar 2020 15:24:48 +0000
Message-ID: <e10eef58d8fc4b67ac2a73784bf86381@realtek.com>
References: <2D8F5FFE-3EC3-480B-9D15-23CACE5556DF@canonical.com>
 <20200102152143.GB1397@lunn.ch>
 <DC28A43E-4F1A-40B6-84B0-3E79215527C9@canonical.com>
 <c148fefc-fd56-26a8-9f9b-fbefbaf25050@gmail.com>
 <02F7CBDE-B877-481C-A5AF-2F4CBF830A2C@canonical.com>
 <80E9C881-91C8-4F29-B9CE-652F9EE0B018@canonical.com>
 <995bddbc4f9d48cbb3a289a7e9799f15@realtek.com>
 <12EA7285-06D7-44D3-B033-4F52A06123CC@canonical.com>
 <cae39cfbb5174c8884328887cdfb5a89@realtek.com>
 <9AAC75D4-B04F-49CD-BBB9-11AE3382E4D8@canonical.com>
 <5A21808E-C9DA-44BF-952B-4A5077B52E9B@canonical.com>
In-Reply-To: <5A21808E-C9DA-44BF-952B-4A5077B52E9B@canonical.com>
Accept-Language: zh-TW, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Hi Hau,
> 
> > On Feb 19, 2020, at 22:48, Kai-Heng Feng <kai.heng.feng@canonical.com>
> wrote:
> >
> > Hi Hau,
> >
> >> On Feb 19, 2020, at 22:22, Hau <hau@realtek.com> wrote:
> >
> > [snipped]
> >
> >>
> >> Hi Kai-Heng,
> >>
> >> Attached file is r8168 that I have add SFP+ support for rtl8168fp. If
> possible, please give it a try.
> >
> > I've already tested r8168 and it does support SFP+.
> >
> > What we are discussing here is to support this chip properly in mainline
> kernel.
> >
> > This is what we've discussed so far:
> > https://lore.kernel.org/lkml/2D8F5FFE-3EC3-480B-9D15-
> 23CACE5556DF@canonical.com/
> 
> Is there anything you can share so we can support this chip properly in
> upstream?
> 

Hi Kai-Heng,

For adding SFP+ support for rtl8168fp, 
1.Some power saving features must be disabled, like APDLS/EEE/EEEPLUS...
2.PHY capability must be set to auto-negation.

I am kind of busy this week. I will try to add support for this chip into upstream next week.

Thanks,
Hau

> ------Please consider the environment before printing this e-mail.