Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4667784ybf; Wed, 4 Mar 2020 08:20:35 -0800 (PST) X-Google-Smtp-Source: ADFU+vtDNDPzMAcPLXZiG6Dj0SS6R9cJhKrWRo6ch5vCcIPOxR9JoVwnVyOvYdNdxq/BT2N3r/QP X-Received: by 2002:aca:dc45:: with SMTP id t66mr2337326oig.39.1583338835175; Wed, 04 Mar 2020 08:20:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583338835; cv=none; d=google.com; s=arc-20160816; b=Yfyzv2zRB99jDBx9JeHvZlxUWsxhhNbHrLezZE1kZG/I3DOwPPZambOc1VM+r5Ai5H PAswJWMvQ+9YblY2BCNvZzYpZLgob60gqT6vmm3mlbHlMPzx0dlvJat5hzE/I87dGmOH aFkjRO6dwvpaYGFtbvGOx2LjrVeBzDso95ryTlJCk0ajHfY9CBN9hd8BQYv5WTu9U+D0 q6stHb9iRmLot8RT443JvCyRnKjHQjKZmXvBrFPuDr4qLm+Fa+BVqQ6s7NunTLdwPefr XmmIhWJTqb7+5FBYEusnPgS5Hz6m+vwFYZULiFOKsJhhFWUpdBSGS3SZJwyavOBVEzxv uesQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cCa2uRExtMb3GygwvZB/IWRHuQIjTpupeIxp3bEFu7A=; b=epE3STUUaKpaKrJbqrUpyjb44z1BIR7dttUrg1/pFD3UqmjxQnklKZYP+zJWdbzD9r RWniQnfNxDHGPAT3/Uli0to651PLs5MsbIkIgsA4UI3yIrw0R3TYX9b+DTRAsI1StJXx aRLJWxSZjqpg3WvRoE0ZAAhvHorTzz3PI7sMWYun8VOAQQ2gVqwwbk9sdK7znG7aBV3A GJbcoITGG47PeL8Sm8+E7hymE524plUiPJGVdq2+W55E5HwscPtV7zuOuQ8nyc0gKLPS Gwkg+32OPGYxB5mJNMlwqS/TbRA3eBuySMLJKS126YhzXLV5+rhUcu2Ys/P9cIk1irSA lOWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y83si1562486oia.94.2020.03.04.08.20.22; Wed, 04 Mar 2020 08:20:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388265AbgCDQSh (ORCPT + 99 others); Wed, 4 Mar 2020 11:18:37 -0500 Received: from mga07.intel.com ([134.134.136.100]:47764 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgCDQSg (ORCPT ); Wed, 4 Mar 2020 11:18:36 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 08:18:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,514,1574150400"; d="scan'208";a="352136478" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 04 Mar 2020 08:18:28 -0800 Received: by lahna (sSMTP sendmail emulation); Wed, 04 Mar 2020 18:18:27 +0200 Date: Wed, 4 Mar 2020 18:18:27 +0200 From: Mika Westerberg To: Nicholas Johnson Cc: "linux-kernel@vger.kernel.org" , Srinivas Kandagatla Subject: Re: [PATCH v2 3/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read" Message-ID: <20200304161827.GQ2540@lahna.fi.intel.com> References: <20200303103310.GN2540@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2020 at 04:07:29PM +0000, Nicholas Johnson wrote: > On Tue, Mar 03, 2020 at 12:33:10PM +0200, Mika Westerberg wrote: > > On Mon, Mar 02, 2020 at 03:43:29PM +0000, Nicholas Johnson wrote: > > > This reverts commit 03cd45d2e219301880cabc357e3cf478a500080f. > > > > > > Since NVMEM subsystem gained support for write-only instances, this > > > workaround is no longer required, so drop it. > > > > > > Signed-off-by: Nicholas Johnson > > > > Assuming this goes through The NVMem tree: > > > > Acked-by: Mika Westerberg > > > > If that's not the case, please let me know. I can also take them through > > the Thunderbolt tree. > I do not know how this would normally work - I have not experienced much > cross-subsystem work. Perhaps it should be taken through your tree. If > it goes through your tree and not part of this series, perhaps it does > not make sense for it to be authored by me, either. It's just a revert; > it does not take a lot of effort or doing something original. Your authorship is fine. Since this patch depends on the first one, it should go together with that one either to NVMem tree or Thunderbolt tree. Either is fine by me but if I take them then I need an ack from Srinivas.