Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Mar 2020 11:54:05 -0500
From:   Tejun Heo <tj@kernel.org>
To:     Tycho Andersen <tycho@tycho.ws>
Cc:     cgroups@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Serge Hallyn <serge@hallyn.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup1: don't call release_agent when it is ""
Message-ID: <20200304165405.GI189690@mtj.thefacebook.com>
References: <20200219190129.6899-1-tycho@tycho.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200219190129.6899-1-tycho@tycho.ws>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 19, 2020 at 12:01:29PM -0700, Tycho Andersen wrote:
> Older (and maybe current) versions of systemd set release_agent to "" when
> shutting down, but do not set notify_on_release to 0.
> 
> Since 64e90a8acb85 ("Introduce STATIC_USERMODEHELPER to mediate
> call_usermodehelper()"), we filter out such calls when the user mode helper
> path is "". However, when used in conjunction with an actual (i.e. non "")
> STATIC_USERMODEHELPER, the path is never "", so the real usermode helper
> will be called with argv[0] == "".
> 
> Let's avoid this by not invoking the release_agent when it is "".
> 
> Signed-off-by: Tycho Andersen <tycho@tycho.ws>

Applied to cgroup/for-5.6-fixes.

Thanks.

-- 
tejun