Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4778996ybf; Wed, 4 Mar 2020 10:28:30 -0800 (PST) X-Google-Smtp-Source: ADFU+vvBALSr9HuGNw1BAfEhMeUartQwHdYBWVkJVc7/1sSId5quF3rVVwke7Tv/EVqVeCkC5I/v X-Received: by 2002:a54:4403:: with SMTP id k3mr2617561oiw.111.1583346509959; Wed, 04 Mar 2020 10:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583346509; cv=none; d=google.com; s=arc-20160816; b=mQW4UXxUThGhu75YEAZwI+mhen6NTWzJRwt18MmYWZVd22Mu8mo2Oz8tirogckoUP8 qn8G0zWnoAqngRrf80P5NR/cx2FfzrK8wzhpsJRgRjDh3BIx7NaR1dICOe6PA97JIJB7 073KRrB2fXQh+vGY8raWvwqMGJqy1IWwY3oOEZe9QCKfOmYYUNGdCMJJsk0ila5hUyoi nRuwfdEOaJ6tELXhu9ZMX9p8Z2ZYclgyTaKvsaBfUNSV3IzC4MjsdYnONVNDIVz7OD1m aXdwwbQmjIUvbh49k5/wjZHTmTIGc6z+f8/Z4T1Gj8iNVXCWLOoiBju/e92vug1SdUxr ixfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6284/+o4WmhRyX/T6Efu7f/wEiL5h9oXcdek5YCPMl0=; b=jdvY+TQYJxUEt0Lsg3ZNXBJSD84LMW657FBVKchWFzO5rz1ocnaqKLWPmrhgjOG3fx XL8upo7VUay3pZxrOwSgNoeTmZWakSrMWOP21OeTg4qMo8uVdsEaAKIW2uZgF3G6pgy2 pE0cLzJXRprQ58dkbiBSjES3K1dGGLxbYedmK1O6lqRkgZNf8TbFrotMqJJW2pLKb3lu G/cLOrE+ga6u41yqVJyG/L6OKXUl2nlqXBcJ4Jc6gcd+3Saj+YubPcrQDBnvga1q98ir ipISsBcxu6HLCMvv37/UvvW/JJwbLy2chkZyWIMDTyH2Z6c+4acL3IjVUiRJWvvP5dkx g3pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=ZEDoJ0Ax; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t6si1751062otp.133.2020.03.04.10.28.15; Wed, 04 Mar 2020 10:28:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=ZEDoJ0Ax; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388130AbgCDS2B (ORCPT + 99 others); Wed, 4 Mar 2020 13:28:01 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:36877 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729965AbgCDS17 (ORCPT ); Wed, 4 Mar 2020 13:27:59 -0500 Received: by mail-qt1-f195.google.com with SMTP id j34so2131447qtk.4 for ; Wed, 04 Mar 2020 10:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6284/+o4WmhRyX/T6Efu7f/wEiL5h9oXcdek5YCPMl0=; b=ZEDoJ0AxZRxKND2ZzOi6Q65C/cHyDa/Fd6mMJzIgN5aluss8TGyYD0JlBups8DESMQ y1koDsk24eHi27dVklM6z3J+t56V82lLAoOs7wqP87AiSEXXkgg2wGUEmbJ5wFi2zlxa iuo8oJ9FJ1iX1Syl3XC9qTrJteSja3Nn4NboxjxzltDjaNM41s0mofINkSNgg2dIb6gL fEfRxbKyfvKXX9Py0SPAKO3EMC3/gMFIpEH0OrC104Yq8i6aDDiUg/Pwoy8uHazSFfdV wSG4xd3x6MkIqR4/x4NA7c889RMT2ahBPgJK4Y1Nti8Ya686nZgXQxcMYFSuzn47xmLs nqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6284/+o4WmhRyX/T6Efu7f/wEiL5h9oXcdek5YCPMl0=; b=Lr+7YjN85vos1AGSpbpfY0qhHvSrPMRG1x6Csjv/euMmsEoeSdV/TUNTtL4bWM0KjL 5kTMnhlU/znih0QGY6/y4nF5DFlWpcA0GpgZ4kZMA7avzrpRdINVcXdYl6EcYoDqT7si 4nGTJ72L4JWFov/5hHSSGCXGl3qTyQ/XolzNupFrSByB7E2dec8O9MunKx2J52b+1l2+ LelTqqXWcP5WUWfkbg9XxlyTU69/wzA5OH6e0UB6cWKg91FVZ6czZScRp8pmNwKaP0qY t3L+J2q9XYQvAdzPhmls0/2mVOE08abcrYi41alnbVGNUt0So277wV10QkwIp06wDa5f y+IQ== X-Gm-Message-State: ANhLgQ1dswod2Zem9TBy4/V3EcDv7eY08AZyd4h/KlAASsuQO8JoxNDT 8oCBFmiJ8ihvRZOIubgeGfqjQVmk4QvkCA== X-Received: by 2002:aed:308a:: with SMTP id 10mr3738127qtf.221.1583346476833; Wed, 04 Mar 2020 10:27:56 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id n8sm14500789qkn.49.2020.03.04.10.27.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Mar 2020 10:27:56 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1j9YkN-0001xY-QW; Wed, 04 Mar 2020 14:27:55 -0400 Date: Wed, 4 Mar 2020 14:27:55 -0400 From: Jason Gunthorpe To: Bernard Metzler Cc: dledford@redhat.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [Patch for-rc v2] RDMA/siw: Fix failure handling during device creation Message-ID: <20200304182755.GA7428@ziepe.ca> References: <20200302155814.9896-1-bmt@zurich.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302155814.9896-1-bmt@zurich.ibm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2020 at 04:58:14PM +0100, Bernard Metzler wrote: > A failing call to ib_device_set_netdev() during device creation > caused system crash due to xa_destroy of uninitialized xarray > hit by device deallocation. Fixed by moving xarray initialization > before potential device deallocation. > > Fixes: bdcf26bf9b3a (rdma/siw: network and RDMA core interface) > Reported-by: syzbot+2e80962bedd9559fe0b3@syzkaller.appspotmail.com > Signed-off-by: Bernard Metzler > --- > v1 -> v2: > - Fix here only potential system crash during failing device > creation, but not missing correct error propagation. > > drivers/infiniband/sw/siw/siw_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to for-rc Thanks, Jason