Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4795345ybf; Wed, 4 Mar 2020 10:49:30 -0800 (PST) X-Google-Smtp-Source: ADFU+vt1Xd99w7Y63Iqy4AwCVZ9hlFeHK+ngOL8FoGusmTPkA5rELp66RA89ZcyF6pNcEgA/LSKo X-Received: by 2002:aca:37c3:: with SMTP id e186mr2848818oia.155.1583347770776; Wed, 04 Mar 2020 10:49:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583347770; cv=none; d=google.com; s=arc-20160816; b=qrkeGTWVKaGQY10qJTWdjNSHQWn31yJzROhrVe2VcBpfqNEmV5CfPaRgI7KrwKgaoX q5tuqlii999/9t3mBLezU0fnCRMJexz+0A0X0iqgezUeARhFV7tvvJFLngP2edQlHjPl epFeJl5g0riO1tFRpl4m+sBaFZYGLk2/ueOFOcjtOKoQyEmVvg1AAhvMDWECLoBWgd+j SpIbXzRGfATHPO4Im7sJfYQ9Kpn1jpVkXtE/ush9bxl4zW1gxEFCQ/jha/UhZJ4SFLgS 7QT7thjym2PB2xN2CWS/oNdy5XRTGyfLytJgXbXZG1VtH4Csml4uaN4zFYOgOfgY5Ll7 s/6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=S9W7e0eEucLRc1ffg2OOLPtWfKH/j6fIgfCoT9zkmQ4=; b=vqFO0hJ6VhkTcKk5S1KcSslYmTbDobpQeVnpap93DD6CXTfW1RJdVT7jDvqVfCxCdi k8DbDjO5nyjgM2vyhd8POM38r54vVZqLjwVT9ZxH0U2lT0UxyDKNcqV1hfXvOLLzcRjh UjMMd4hLdH7XGtk+wll88hpXl0ptlNhzfQV4qHTrO9lCz0ov03J2I6nwLOpHcC/3C/ka BUeC1AMl/gO8dHVixSZhMKmj9jn5Ctaz99mN6kt9/Sz5PW2muolaY4nh+2vvawltG27K XFiiXH6tcvhSuk6AFps+Oq5CZL19pgXltDHxVlHgGtEwWlqkiUynQFaRWpPN6ZJUooVz vYtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=sruLBKDX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si1713214otp.0.2020.03.04.10.49.19; Wed, 04 Mar 2020 10:49:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=sruLBKDX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730249AbgCDSsH (ORCPT + 99 others); Wed, 4 Mar 2020 13:48:07 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:42373 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729600AbgCDSsG (ORCPT ); Wed, 4 Mar 2020 13:48:06 -0500 Received: by mail-il1-f194.google.com with SMTP id x2so2708624ila.9 for ; Wed, 04 Mar 2020 10:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=S9W7e0eEucLRc1ffg2OOLPtWfKH/j6fIgfCoT9zkmQ4=; b=sruLBKDXI+8Re66Y+pWX8pNUETxHXEbhvy5dnTtswbvWs5f5SR9ZMgjcV+MVofdwr4 gg1Ju2kOUjY/nPmXMSVmqkWPj5FGdh7PApD6CKl+lkoUtYVmrrgnJQQVv///uq4KOHAT Xgd5tSc7aXzPQxIleSo8JgEQ594fi0l4XuCUwuiD5rBTPeyy3eg7E9u/w49YqJR+kp+C 0TAUTXW+Bq/tq56HcXrlOzF5lTs0WVcOhyxOI7EHlsa2dQbZDrMN36EQCzyL4PkV9GF5 chkQjw0uKaBgcIRpMKYUsTvwM4BVn8qts5lJEuLQoa+O1y7SBQS0wExrI6wJXChvJemH OvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S9W7e0eEucLRc1ffg2OOLPtWfKH/j6fIgfCoT9zkmQ4=; b=nAsdFPRPdz8srCUPQE5jjdDHVGmT4pwkrKaBHgFP/Nr9rnBsu285HDWXDZ5c4D9NKX MzTnT0KmZzYginHWWNtsFmJzdMfjemaTgt7BHMdgqf27HGd9kGNsHCZq1E7NyW3snsyX EU3oxxlE1G8dfNc6DSs6gTNIvhKLYCJyT7tgCBZNLEP+aC0ppqg9+RyMfz9aZB6C5MWO r/zG5QHg/tFYZAqKnxszaf7ebO9tfBmAqjvErVAnzWlDS+cAWmHbyJe4L1/nKYgYIOrp 2AJq/GZQjORNTi7VQ//m756mfhsTkCIqndHf6Q4kqlPRifVUhlzU055TkFFshwJcALkz Pj+Q== X-Gm-Message-State: ANhLgQ2imItXUHXZsDyH/BrkSf7uhnLf5+Xd3WaHq8Rhg67GBOR0h5d/ OuJtuAZCMZfE6eFxbcc3biLHuRbF3ns= X-Received: by 2002:a92:d782:: with SMTP id d2mr4233240iln.42.1583347684414; Wed, 04 Mar 2020 10:48:04 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id c12sm9381900ile.12.2020.03.04.10.48.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2020 10:48:03 -0800 (PST) Subject: Re: [PATCH 0/4] io-wq/io_uring locking optimisation To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <9aeadaac-b225-7988-cd43-d0db565961e6@kernel.dk> Date: Wed, 4 Mar 2020 11:48:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/20 6:14 AM, Pavel Begunkov wrote: > [1-3] are shedding excessive locking of @wqe's and @worker's spinlocks > from io_worker_handle_work(). > > [4] removes an extra pair of refcount get/put by making former io_put_work() > to own the submission reference. It also changes io-wq get/put API > and renames io_put_work() into io_free_work() to reflect it. LGTM, and tests out fine so far - applied, thanks. -- Jens Axboe