Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arvind Sankar <nivedita@alum.mit.edu>
Date:   Wed, 4 Mar 2020 13:48:04 -0500
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>,
        linux-efi <linux-efi@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] efi/x86: Move mixed-mode thunk to efi/libstub
Message-ID: <20200304184804.GA263581@rani.riverdale.lan>
References: <20200304183659.257828-1-nivedita@alum.mit.edu>
 <CAKv+Gu_Bc5WYG_D7cM_fPi8rV65ouEre8uYUck0FCxN9FSUopw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKv+Gu_Bc5WYG_D7cM_fPi8rV65ouEre8uYUck0FCxN9FSUopw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 04, 2020 at 07:39:23PM +0100, Ard Biesheuvel wrote:
> On Wed, 4 Mar 2020 at 19:37, Arvind Sankar <nivedita@alum.mit.edu> wrote:
> >
> > Commit c2d0b470154c ("efi/libstub/x86: Incorporate eboot.c into
> > libstub") moved all the callers of the mixed-mode thunk into
> > efi/libstub, so move the thunk itself as well for completeness.
> >
> > Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> 
> Thanks for the patch, but I'd prefer to leave the .S pieces under arch/
> (unless there's some benefit I'm not seeing)
> 

Ok. I can't think of any objective benefit.