Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4796626ybf; Wed, 4 Mar 2020 10:51:11 -0800 (PST) X-Google-Smtp-Source: ADFU+vtVCyF20i9AFznzYzCyQwdYCYqPp0mwPl245pGT+l9CsUMmoHhe5beGcqAy4GF9Em+V1UnY X-Received: by 2002:a9d:64b:: with SMTP id 69mr3363339otn.237.1583347871316; Wed, 04 Mar 2020 10:51:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583347871; cv=none; d=google.com; s=arc-20160816; b=F0XCprSy/UAOvsYjJcnjv4mwrCNeG+jzTtLjUBxmlapV5AlDXazS3iiYAfXazt2xb4 tslpvL6uCwwiZL6PlPJ7YeaxIUuWFLooZJF44Gi3KXSiqsxzFUR1pefhoXHo7J55Ngpc qeBScUOLlowWwopkdsl810fiBjvk8+E2XqjYYkpGTR4wWfRjfFgQbi+lBFaPFY3uu752 /BWfJ0UoFyNfaFx1j7p88rHyEU/UH7N+nAxjoZagrt76k6qe6TIg58eMV8a0gZs/2488 yRdCIRihHVqhTqDiaSRh9yxTJNx36Jm6an+FBjQ2JEgrwIQBlglVQUOnVjCfw75aVtWw zDIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:date:from:dkim-signature; bh=tuKeD8w66KIDzJ6/Silhroq3Yhej0TOjlxLZqNMh/QM=; b=BXj291WGSOgS07ZVZOalRASCwjm8T2UxccRQSfn5SuC1ggYv333S3BEG4AWpj2NDCA cJSP8OA3JR/JbC636lHMfBq6rkX+VNveEw2z4fHgP8nh1WJbtd8THfRhJtgeQU7yDptT FpSe/d9xiqbG/ofVrW6NVls9jWeXhaIllfER5w8UpVjbnf1symrndsoNNBCkLdU13piW NwgApI1jcp7v6N6kxv5K8T5EdXdZz1bIU93hOIgoP8bdnHwlVZUqdRp2AXMw+Kq7zI2c DMGJ4ENlMWO2nWfi2cbZX6/zfn+Jos2GpLTXjVeg34MCt+W71JEMOJl9qutWrZ7kWomg aR/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=K1STWgSZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s15si1816987otr.16.2020.03.04.10.50.58; Wed, 04 Mar 2020 10:51:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=K1STWgSZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730117AbgCDSup (ORCPT + 99 others); Wed, 4 Mar 2020 13:50:45 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:34629 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729600AbgCDSup (ORCPT ); Wed, 4 Mar 2020 13:50:45 -0500 Received: by mail-qv1-f68.google.com with SMTP id o18so1273697qvf.1; Wed, 04 Mar 2020 10:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tuKeD8w66KIDzJ6/Silhroq3Yhej0TOjlxLZqNMh/QM=; b=K1STWgSZRij5Bsdjl9V2EgJs+J4iSVnfdNGfBDMF3VM4W1yBesmPlhQBeCIAEPoAIG UKdX5a5JpcF1I0AwopypkUDjo2YD1SdgU3aj+54kL1E0T0y+jwAf+RIprktg2kdRlYet +VZkbdPAHsJzlYHJ7dZX7TgJ+pJKfSgjH4ejwDfBOEHMQMK4PBSBDZBV2RqTwu+v5yRk l1QxwcdJAT2wGgHSsgzhrLrgA7K9vtpGGKe+oRm+smgX5PjaItVnANiJD/MAssgGZOen syKJx9ycWoI6Io4rfbz74u0LITlLoAVSNdtnP6c4Unxj5fWFH/Wn0fb0m2KCLlvR3Oj4 EErQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=tuKeD8w66KIDzJ6/Silhroq3Yhej0TOjlxLZqNMh/QM=; b=HCf0+ww7O8wtnA/6cLGQ0Kkko6SzIqsKD5sRUIU5AVgZgLssaUvPusi3C3LdSi/peg 6ydHbgkILldtcz3JtzU/F7agXPctBH2uJyGN4792YwgehXGJHoQsgMGNzFVqaxZ8LFim BiukQonzZ88z27w3hSQXFs4sA4qhNNpa36gJZB3FvuFyqtSEKqXBDcx6l7mF7ti6jgJ3 U8Ttd2OradKMVXL5GbLQtC3WXNrkNcpOnrj86JCF+k9dWYYuRf9U3Y9Sq2xFtPDMDD4m C3xb6V0ufMPkutyhZhy3yWvC4vofZMsvusZl7oVVaAuXeq3J6323RXm50/iZUOvVN276 U24A== X-Gm-Message-State: ANhLgQ1xbZ+q+wZTH+3DFemKylKihue/o36W/OrTsd6LGaAHi/Ame+Rq Q5m5mR3kvj4LEhjY9t6MFs8= X-Received: by 2002:a05:6214:1933:: with SMTP id es19mr3223597qvb.14.1583347844236; Wed, 04 Mar 2020 10:50:44 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id 202sm14061573qkg.132.2020.03.04.10.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 10:50:44 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Wed, 4 Mar 2020 13:50:42 -0500 To: Ard Biesheuvel Cc: Arvind Sankar , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , the arch/x86 maintainers , linux-efi , Linux Kernel Mailing List Subject: Re: [PATCH 1/4] x86/mm/pat: Handle no-GBPAGES case correctly in populate_pud Message-ID: <20200304185042.GA281042@rani.riverdale.lan> References: <20200303205445.3965393-1-nivedita@alum.mit.edu> <20200303205445.3965393-2-nivedita@alum.mit.edu> <20200304154908.GB998825@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2020 at 07:44:50PM +0100, Ard Biesheuvel wrote: > > I've tried a couple of different ways, but I can't seem to get my > memory map organized in the way that will trigger the error. What does yours look like? efi_merge_regions doesn't merge everything that will eventually be mapped the same way, so if there are some non-conventional memory regions scattered over the address space, it might be breaking up the mappings to the point where this doesn't trigger.