Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp4882416ybf; Wed, 4 Mar 2020 12:37:24 -0800 (PST) X-Google-Smtp-Source: ADFU+vuirmrnmT19ZLVDivc6GpQVLGTSCsovjd71MFlkr4q5WrND0HNMpUGCKnvE2quBjCpMwwkp X-Received: by 2002:a9d:2264:: with SMTP id o91mr3862152ota.328.1583354244402; Wed, 04 Mar 2020 12:37:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583354244; cv=none; d=google.com; s=arc-20160816; b=XysYM//WaYclUgwLOhruYdt7uOW//MC/Eas2692GRah/v07fkl5EIfSEW6nJsDCPpQ c/PigfuSYdFsZlxbL0/kQI6qo9CSyVQU6/6Y0uMqMJHOM6RpDvXgk9vsjSmFP08bTyym 9DovxbfMk80qujvN2VRvLZtAPeFcUULcO7ZbibFE41cLfeOHMJ6Z5cddmiLRhtgR4XR+ BgiL0mKrgGLewhGW/Oy5HltfAwthHJj5bb0/+lGTAYE0e0Ku4A9uT44kxjg2v4moxHDy EIdTDK58N3CnS7JeWKBhvP7Out7vIq+O9xQ55owchwKldb/TTkf3tvX4ZjedSQ+2rKc7 XgNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WWpK2UGoIxYLT5HYeScp8RO9gcOMg+mhjKPpX7A/VKM=; b=ExeJyQtbxRZ/bXznLY/lAHFotLle7qq1PyVk4TjPJDz/3Gra5s21R0nNfc3N64cdme 1Q5tJINS7P8zCyoli+VBaCcxfVKOixETkhK152YnQC9GxpiaORaZBE2AC9D/3LXOWsip a1IEsCtaFFcPRcAP6QmeIPgU/eNUjWYGGw/pQbqzYA2u5B21UOKe2+soPfMEBXDvQg+X lBp8vBMCVxtCOQ8GuHI5FtRuxl6F+wqK/TAKse5hOloujp8fm8veUY4roXQfa0mJ7fv4 BjATwOldmM1PzqvxtGAWG/RgEp1D3gBkubmNporije6mqOE3Qajd8dssUK7xgOhMrVp7 a6fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BsIfeXJ3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si1890244otq.194.2020.03.04.12.37.12; Wed, 04 Mar 2020 12:37:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BsIfeXJ3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388533AbgCDUgo (ORCPT + 99 others); Wed, 4 Mar 2020 15:36:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:36780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388518AbgCDUgm (ORCPT ); Wed, 4 Mar 2020 15:36:42 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75C7A217F4; Wed, 4 Mar 2020 20:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583354201; bh=UA2EJhJ9qhxldAsKSkyx/y87EvRgFN4/kWezr3S1WVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BsIfeXJ3L18wF9II8BsCzkdWK/EciMgm5A3ZkWigYiAwEn6ObyKezCl0XrbAIXFoL OkQ34skIvzhclK1SkT/XnGVyWaOwJXrbdJwon4/bBSIHqpk4V3snKRBIw9qLCr5SDT KOEE/piGaf6jNYUy5l96CR/qwxaaCKMTG/f2sFdk= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9ajI-00A59R-3o; Wed, 04 Mar 2020 20:34:56 +0000 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lorenzo Pieralisi , Jason Cooper , Robert Richter , Thomas Gleixner , Zenghui Yu , Eric Auger , James Morse , Julien Thierry , Suzuki K Poulose Subject: [PATCH v5 22/23] KVM: arm64: GICv4.1: Allow non-trapping WFI when using HW SGIs Date: Wed, 4 Mar 2020 20:33:29 +0000 Message-Id: <20200304203330.4967-23-maz@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200304203330.4967-1-maz@kernel.org> References: <20200304203330.4967-1-maz@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, jason@lakedaemon.net, rrichter@marvell.com, tglx@linutronix.de, yuzenghui@huawei.com, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just like for VLPIs, it is beneficial to avoid trapping on WFI when the vcpu is using the GICv4.1 SGIs. Add such a check to vcpu_clear_wfx_traps(). Signed-off-by: Marc Zyngier --- arch/arm64/include/asm/kvm_emulate.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/kvm_emulate.h b/arch/arm64/include/asm/kvm_emulate.h index f658dda12364..a30b4eec7cb4 100644 --- a/arch/arm64/include/asm/kvm_emulate.h +++ b/arch/arm64/include/asm/kvm_emulate.h @@ -89,7 +89,8 @@ static inline unsigned long *vcpu_hcr(struct kvm_vcpu *vcpu) static inline void vcpu_clear_wfx_traps(struct kvm_vcpu *vcpu) { vcpu->arch.hcr_el2 &= ~HCR_TWE; - if (atomic_read(&vcpu->arch.vgic_cpu.vgic_v3.its_vpe.vlpi_count)) + if (atomic_read(&vcpu->arch.vgic_cpu.vgic_v3.its_vpe.vlpi_count) || + vcpu->kvm->arch.vgic.nassgireq) vcpu->arch.hcr_el2 &= ~HCR_TWI; else vcpu->arch.hcr_el2 |= HCR_TWI; -- 2.20.1