Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp5113039ybf; Wed, 4 Mar 2020 17:36:18 -0800 (PST) X-Google-Smtp-Source: ADFU+vsjOj75I1Lu9SGc2lUwQW56EsHBFtP2JkMZy12/X/lWyOz3qaAgaGwI2iBzPClyxTIYiMwF X-Received: by 2002:a9d:70c8:: with SMTP id w8mr4827061otj.144.1583372178561; Wed, 04 Mar 2020 17:36:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583372178; cv=none; d=google.com; s=arc-20160816; b=nDE15FadYNRqjxi488hXn092QpKKHweFHjpnDoMBuRSE8Nsdgh0kVgndlaGR5gn4Y5 bOFtW17PG6k9vz7vWKbgAEsZjR9xqySr2QoKBKFDZZeYVXsL3TEhx/lujfYcZ7aikT4b bboQbo/+Yj0xJjlTC1htUL6dCgA1xPOuqxdM8zCSMqovwI3ENsHCQMQ5UxcE3mibC3Zy sqE38TuWd5JOjFpAAtPkP9+X0NCyS7ZtiW3o7JyMsA2BXMj61Y71cmz6NX/dJMYFLu9U FIfsA7PWMYubYerbkSmpRvb8JOI+s23WZ2qPt1QaDDgdCR+aPnntH8OoX0QasrVGsLr3 a4dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RTea2Qq+H6h005Z/UwueNu6fNc6FSbxXPYFwGmdtpe8=; b=ed3YkMosGRB8bfsAXS6n8FXFq0X21TKY7+ZX2wy13p6hJIdXK2XW7MXljJslm0RS56 FTHRpEVA2p2fXgX9QB2JnHJ8+XxyDLEaAJND2yn7Qga+e/wgVu+Wf4Bd7pxNRKFexrb5 uLoLpZNIO2jJuqoDfZpahGsopxuan4aRW7PMvuqJQdlP3Ge2pwh15PxHMNqWj5kyB684 NEGI0cJt1BOJVu0OVNHzl1A0X11zWyAfjdIHCTwF0ywnvof58OdKRi8U8zq7OQnpcDdJ h6boHvoFMEeHx89TOJ2JitjsI7U/uw6w+ANlDjUi7+LQWC5m6dJVOG5rTEEWn6ImWkPI MSRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d22si891895ote.183.2020.03.04.17.36.06; Wed, 04 Mar 2020 17:36:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725919AbgCEBek (ORCPT + 99 others); Wed, 4 Mar 2020 20:34:40 -0500 Received: from mga03.intel.com ([134.134.136.65]:31855 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgCEBej (ORCPT ); Wed, 4 Mar 2020 20:34:39 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 17:34:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,516,1574150400"; d="scan'208";a="234301737" Received: from sjchrist-coffee.jf.intel.com ([10.54.74.202]) by fmsmga008.fm.intel.com with ESMTP; 04 Mar 2020 17:34:38 -0800 From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Pu Wen Subject: [PATCH v2 0/7] KVM: x86: CPUID emulation and tracing fixes Date: Wed, 4 Mar 2020 17:34:30 -0800 Message-Id: <20200305013437.8578-1-sean.j.christopherson@intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Round two of trying to wrangle kvm_cpuid() into submission. Two more bug fixes, both related to querying for an "AMD" vendor, in addition to the fixes in v1 (tracing and Hypervisor/Centaur range checks). In theory, everything up to the refactoring is non-controversial, i.e. we can bikeshed the refactoring without delaying the bug fixes. v2: - Use Jan's patch to fix the trace bug. [Everyone] - Rework Hypervisor/Centaur handling so that only the Hypervisor sub-ranges get the restrictive 0xffffff00 mask, and so that Centaur's range only gets recognized when the guest vendor is Centaur. [Jim] - Add the aforementioned bug fixes. - Add a patch to do build time assertions on the vendor string, which are hand coded u32s in the emulator (for direct comparison against CPUID register output). - Drop the patch to add CPUID.maxphyaddr emulator helper. [Paolo] - Redo refactoring patches to land them after all the bug fixes and to do the refactoring without any semantic changes in the emulator. Jan Kiszka (1): KVM: x86: Trace the original requested CPUID function in kvm_cpuid() Sean Christopherson (6): KVM: x86: Add helpers to perform CPUID-based guest vendor check KVM x86: Extend AMD specific guest behavior to Hygon virtual CPUs KVM: x86: Fix CPUID range checks for Hypervisor and Centaur classes KVM: x86: Add build-time assertions on validity of vendor strings KVM: x86: Refactor out-of-range logic to contain the madness KVM: x86: Refactor kvm_cpuid() param that controls out-of-range logic arch/x86/include/asm/kvm_emulate.h | 37 +++++++++- arch/x86/kvm/cpuid.c | 111 +++++++++++++++++++++-------- arch/x86/kvm/cpuid.h | 8 ++- arch/x86/kvm/emulate.c | 64 ++++++++--------- arch/x86/kvm/mmu/mmu.c | 3 +- arch/x86/kvm/svm.c | 2 +- arch/x86/kvm/x86.c | 7 +- 7 files changed, 162 insertions(+), 70 deletions(-) -- 2.24.1