Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200303065210.1279-1-zhenzhong.duan@gmail.com>
 <20200303065210.1279-3-zhenzhong.duan@gmail.com> <ba5067ad-4fba-52c9-6872-c18bfeb947db@intel.com>
In-Reply-To: <ba5067ad-4fba-52c9-6872-c18bfeb947db@intel.com>
From:   Zhenzhong Duan <zhenzhong.duan@gmail.com>
Date:   Thu, 5 Mar 2020 12:03:26 +0800
Message-ID: <CAFH1YnN01PtCBm_92m3CPRhsiS2Bzis8q-vOJ5q+_LUq8ZoZqg@mail.gmail.com>
Subject: Re: [PATCH 2/2] x86/boot/KASLR: Fix unused variable warning
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Borislav Petkov <bp@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 4, 2020 at 6:56 AM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 3/2/20 10:52 PM, Zhenzhong Duan wrote:
> > Local variable 'i' is referenced only when CONFIG_MEMORY_HOTREMOVE and
> > CONFIG_ACPI are defined, but definition of variable 'i' is out of guard=
.
> > If any of the two macros is undefined, below warning triggers during
> > build, fix it by moving 'i' in the guard.
> >
> > arch/x86/boot/compressed/kaslr.c:698:6: warning: unused variable =E2=80=
=98i=E2=80=99 [-Wunused-variable]
> ...
> > diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compresse=
d/kaslr.c
> > index d7408af55738..62bc46684581 100644
> > --- a/arch/x86/boot/compressed/kaslr.c
> > +++ b/arch/x86/boot/compressed/kaslr.c
> > @@ -695,7 +695,6 @@ static bool process_mem_region(struct mem_vector *r=
egion,
> >                              unsigned long long minimum,
> >                              unsigned long long image_size)
> >  {
> > -     int i;
> >       /*
> >        * If no immovable memory found, or MEMORY_HOTREMOVE disabled,
> >        * use @region directly.
> > @@ -711,6 +710,7 @@ static bool process_mem_region(struct mem_vector *r=
egion,
> >       }
> >
> >  #if defined(CONFIG_MEMORY_HOTREMOVE) && defined(CONFIG_ACPI)
> > +     int i;
>
> Won't this just result in a different warning since it now it will
> declare 'i' in the middle of the function once CONFIG_MEMORY_HOTREMOVE
> and ACPI are enabled?

I didn't see a different warning with both configs enabled, because
-std=3Dgnu89 isn't
enforced in arch/x86/boot/compressed but it does in other part of kernel.
C99 and above allows declaration in middule of the function.

Zhenzhong