Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp5447873ybf; Thu, 5 Mar 2020 00:53:29 -0800 (PST) X-Google-Smtp-Source: ADFU+vuIFKlhj25A4EYhKlohhMT9WJ0KHSlkGkbWfRsYr72fPTIzKkF8VU1NkAZDoA1aAVtogdDu X-Received: by 2002:a9d:7c81:: with SMTP id q1mr5680872otn.112.1583398409162; Thu, 05 Mar 2020 00:53:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583398409; cv=none; d=google.com; s=arc-20160816; b=ogL+q1Qe7kScXzrZuVQV9qQmq0Em4q87ukAK7tlONzzIgI4LQf4aM2iCxAOlzVo7iB 2Hk1vk80HxszJ9/SGkD7iT8EO9RsQ3CxI6y8CzsnM8L3p6wxbOJkuWJsvGE1kdzUG0Nu 9RVlLeIcbEH6tND4AxJk1IA+FXALKI9lLP1E+XRFOAahgw1Wpzc3nPaJce309kQQR5Gp zGwlZu0T9riVpgzokvnZntEMwL/0eOC2cI3T3ECtc2qgt4KSxEVoCI6K+GWQ17wOE6X0 uEW1XsjJj6s92gVsibTgy0nTlWSDm2cq0m+bV9j75ESJSJSgDOB1VMSxKfMdaN3HY1p0 afZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FrinyHvJ3EJNcSYcUq5w0Pmcfu/o7CX3aYAFQvjsJ2Q=; b=DowXP1sXozyBgTtkbkLaMhC/ODCFsr/8Nv54Ff2itUKbmLh43uCwGKPUt1D+VWW7Ps ei7nHVKf2q8d6FwAXlt+BwfVdX2TgRQCFsgwqYlES6U5ag2c16BMG/+YkKijAZQGxlls 675KJ5W9ko/q2wy+nuNSswW02jw9sybxI8m8zu8VBKrz/J0bmitcihP3RrjZbd08fbzW lYUptk234bFuGMVkOKrjcQzCd9d+59Lxsp/eh+3U+AarJxeST53OomLxTa22KXQJZLRx +POaG5GdrH1RyPYZj1ji9cBQ5h53WxQJMKxdMXa1cE9U2yeOcjSRx8IJCSZI+SExaZpF pjGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r4fzgfaM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h16si3014307otk.193.2020.03.05.00.53.17; Thu, 05 Mar 2020 00:53:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r4fzgfaM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726220AbgCEIvc (ORCPT + 99 others); Thu, 5 Mar 2020 03:51:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:42812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgCEIvc (ORCPT ); Thu, 5 Mar 2020 03:51:32 -0500 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 644F32146E for ; Thu, 5 Mar 2020 08:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583398291; bh=0cu+E7SCRqW6qkQHGXrzeQ+THUKLi1C1UePfJyu621M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=r4fzgfaMgkKh+As+J8drFx6XKOa59EaD3zNOFsNH76p0Vz4E8Gozfob3HT2U1GdhD 49pnayl9w7uPl/YibyEKehJCohTD7tjNPxNdIZRknXQ/nsU+jpPU9oP55qe1j6enCZ KoMjOYtEebuTRua40kfCZIr51ysrzmt2fveEq29E= Received: by mail-wr1-f54.google.com with SMTP id z15so5969798wrl.1 for ; Thu, 05 Mar 2020 00:51:31 -0800 (PST) X-Gm-Message-State: ANhLgQ31O5vP3xP6bKuuyjL3f2WIhnjc2Rk+SLT7oD4z1wp6qWZOXamk A8QxgSt+av+Tjqo9FOtlmYUEJdfqzty+I+Q04jDwdA== X-Received: by 2002:a05:6000:110b:: with SMTP id z11mr9167986wrw.252.1583398289927; Thu, 05 Mar 2020 00:51:29 -0800 (PST) MIME-Version: 1.0 References: <20200305084041.24053-1-vdronov@redhat.com> In-Reply-To: <20200305084041.24053-1-vdronov@redhat.com> From: Ard Biesheuvel Date: Thu, 5 Mar 2020 09:51:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/3] efi: fix a race and add a sanity check To: Vladis Dronov Cc: linux-efi , joeyli , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Mar 2020 at 09:41, Vladis Dronov wrote: > > There is a race and a buffer overflow while reading an efi variable > and the first patch fixes it. The second patch adds a sanity check > to efivar_store_raw(). And the third one just fixes mistypes in > comments. > > Vladis Dronov (3): > efi: fix a race and a buffer overflow while reading efivars via sysfs > efi: add a sanity check to efivar_store_raw() > efi: fix a mistype in comments mentioning efivar_entry_iter_begin() > Queued in efi/next Thanks! > drivers/firmware/efi/efi-pstore.c | 2 +- > drivers/firmware/efi/efivars.c | 32 +++++++++++++++++++++++--------- > drivers/firmware/efi/vars.c | 2 +- > 3 files changed, 25 insertions(+), 11 deletions(-) >