Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ASoc: amd: acp3x: Add missing include <linux/io.h>
To:     YueHaibing <yuehaibing@huawei.com>, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        akshu.agrawal@amd.com
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20200304084057.44764-1-yuehaibing@huawei.com>
From:   "Agrawal, Akshu" <aagrawal2@amd.com>
Message-ID: <5d205b07-32c4-db9e-76bb-936bca3247ce@amd.com>
Date:   Thu, 5 Mar 2020 15:37:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.2
In-Reply-To: <20200304084057.44764-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.136.133.153] (165.204.157.251) by MAXPR01CA0084.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.15 via Frontend Transport; Thu, 5 Mar 2020 10:07:14 +0000
X-Originating-IP: [165.204.157.251]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: a222705f-b7c9-4877-e6c2-08d7c0ecfbec
X-MS-TrafficTypeDiagnostic: MN2PR12MB3950:|MN2PR12MB3950:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB3950BF3EC28FA5F0990826F7F8E20@MN2PR12MB3950.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-Forefront-PRVS: 03333C607F
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(189003)(199004)(16576012)(316002)(31696002)(66476007)(53546011)(66556008)(5660300002)(6666004)(26005)(4326008)(478600001)(6636002)(2906002)(16526019)(186003)(36756003)(6486002)(66946007)(31686004)(8936002)(8676002)(81166006)(956004)(2616005)(81156014)(52116002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR12MB3950;H:MN2PR12MB2878.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 40YL7ogObNXY6l/8FCEi2t3is58UdsqLm3c+5Buv6/7wlCzWp7Y7wDCPYNXIwBtQWLETh4/9hY+ZqyPj7kI01LNxW7b1I1tWvWcG8t+491gCVPwM72liZr0zPaOImDgUHmu1YxCUy3T/uT9Ha3lkWSb6TFJzxsaOPV521uut5rWZSP20cQ/7VoVdNxDqEkEc8EQRHSQtSQh8anHTr+SxxZQHhUi/XNOSHWlmO5SU8VdmC4hc5qiAQ5uBejtvLsZxgdttFpCbqcFt8SIuwUqpULfTGYEHKoIs3LDkpwDX7I8YP3u8UnHP/THpLxGldGq1ryRVPVa+LF0vmK2ruqGiQRraEv9+5PATV3dAVwlSRHjis+DqefHoL1ve8Vm9ptA894bUxeGRgbRDLSo0oJCbsC/+uuFe2hVCteONJTiYFUjMTZq8TIRdxlm6C46ByYedDqCalKLVSa+d4CllwzlnwX1dg6emPp7ha6dP6a706u12DKhSKtIaAX8Bs7DoM04L
X-MS-Exchange-AntiSpam-MessageData: 6PC4YTLapYAy+QY+6gouEDGrQZlKa4pJJcERf5drhE4BzGtkHgd4bGse3AewLNf4yf9tUztYISKk0WgKftDxm3QTc5ZzVclwQohIMYBRfXS111pTXhKPSIh/zdHnC6LsiqCD1KSiXyq8oB/aGmgzCQ==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a222705f-b7c9-4877-e6c2-08d7c0ecfbec
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2020 10:07:16.9275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7hUvoJDsc1toMSUxxnOyOLYb1pO8SuXlcXoyFpKv4Va9mMwKu8zPdNA6Ddj3XZ+uxh0qv99Ti0nSt0LhCRs+3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3950
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/4/2020 2:10 PM, YueHaibing wrote:
> gcc 7.4.0 build fails:
>
> In file included from sound/soc/amd/acp3x-rt5682-max9836.c:20:0:
> sound/soc/amd/raven/acp3x.h: In function rv_readl:
> sound/soc/amd/raven/acp3x.h:113:9: error: implicit declaration of function readl; did you mean rv_readl? [-Werror=implicit-function-declaration]
>    return readl(base_addr - ACP3x_PHY_BASE_ADDRESS);
>           ^~~~~
>           rv_readl
> sound/soc/amd/raven/acp3x.h: In function rv_writel:
> sound/soc/amd/raven/acp3x.h:118:2: error: implicit declaration of function writel; did you mean rv_writel? [-Werror=implicit-function-declaration]
>    writel(val, base_addr - ACP3x_PHY_BASE_ADDRESS);
>    ^~~~~~
>    rv_writel
We don't hit this error and neither with i386-allyesconfig. Would be 
interesting to know with which config do you get this error.
>
> Add <linux/io.h> to fix this.

Since readl and writel are used by acp3x.h, it would be better to 
include linux/io.h in acp3x.h and avoid including it in every file which 
includes acp3x.h

Thanks,

Akshu