Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp5557916ybf; Thu, 5 Mar 2020 02:53:45 -0800 (PST) X-Google-Smtp-Source: ADFU+vvipJzWvdlT7etsY0tSdESvOlRWteSZM88W28Y8VcfeHhnHPXtKPgomvQykbuWzcYLVv+gg X-Received: by 2002:a05:6830:57:: with SMTP id d23mr6193537otp.224.1583405624761; Thu, 05 Mar 2020 02:53:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583405624; cv=none; d=google.com; s=arc-20160816; b=kAZrp0ZHu0BbT4UAdTpinS25qOqGVQNSpgz2apK8WD5RrcVhc98BMkhfUO71jPvQHl hhxBgFzF7dPVHSfXytEaBB0MBTp1Iq8f4ksHMyj7SUfqMq8J0h9NWNOHx1ajNtratyAO tQzGa3q7USfFTHjPIWaGvsS30yEnrQhljTlH3LwxWvq8ArF87NixsNwDt4G1JEBNye+0 ky0Yt5qfs/6vbOMvjCAcKO6lu2Eyg7x8ipxkIlf+uzlTcBFMb59zieiAJqG/KoBad9Yu PwQYMgNMfPI7ohDIPECfXBXacDDbMqRyVs6FISOj82ng9pmMMVwO+pKLDYgXiGNqxrhw qTMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:dkim-signature; bh=UI+jv9WRtSfSOrEtwCJt1VuJ+panaiTzk05DWwgj8hE=; b=HgsQQYdlcnReCgM5b5aN/529E4fPIjVa1Q1MC/FhQ+XsXHHW1RkWaHYiZrRqGrIpZQ 4JHK+fH9A4Tlhx2lnua0sThsoHaDSZt3eyC2PzeTInExgFGuccnGS+ktzO++aGuAaiBR QY2Q1djhHvazqxVhQtQ/tC66e38TMqq+MpwT5BPB7rhtQLKRLHTmSSKXU+rMIS2ca1VY n2Z9uqwl0o7XSiz1eMkp7kuyLzDjgS8JF8CVZ5xfu9KmfrRMtGkUm2TdZTvgieTlnO0f XEZeNVpP2OLk87bi3MAdOlyLjMMkSAHyFBi9/emQ0GpdY1yXV7/SaRC0dxY6J6tJNVni kFKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zocv2NxY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c83si3615972oig.116.2020.03.05.02.53.32; Thu, 05 Mar 2020 02:53:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zocv2NxY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbgCEKwN (ORCPT + 99 others); Thu, 5 Mar 2020 05:52:13 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:45848 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726979AbgCEKwM (ORCPT ); Thu, 5 Mar 2020 05:52:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583405531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UI+jv9WRtSfSOrEtwCJt1VuJ+panaiTzk05DWwgj8hE=; b=Zocv2NxYtS+xF7k3linUcXvCwyDCnMDz42RUMozA0PAqXhaP2NKLGXu49O3+axWAuJQFZU xKDR5ZlZgCVBoBYE7Mpefq1CuUABRktWSIz9tWYmTDsHjF2OAVIYc12ru2+nsC9ebhoORO g+1UIvf2Flv8dACQ63tWeeuuBdFUEo8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-Ix9rltTnOy6V2Odi6gbcew-1; Thu, 05 Mar 2020 05:52:05 -0500 X-MC-Unique: Ix9rltTnOy6V2Odi6gbcew-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CE67800D50; Thu, 5 Mar 2020 10:52:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42E455C219; Thu, 5 Mar 2020 10:52:04 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3363D1809563; Thu, 5 Mar 2020 10:52:04 +0000 (UTC) Date: Thu, 5 Mar 2020 05:52:04 -0500 (EST) From: Vladis Dronov To: Ard Biesheuvel Cc: linux-efi , joeyli , Linux Kernel Mailing List Message-ID: <911968708.13281322.1583405524154.JavaMail.zimbra@redhat.com> In-Reply-To: References: <20200305084041.24053-1-vdronov@redhat.com> <20200305084041.24053-2-vdronov@redhat.com> Subject: Re: [PATCH v3 1/3] efi: fix a race and a buffer overflow while reading efivars via sysfs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.204.231, 10.4.195.11] Thread-Topic: fix a race and a buffer overflow while reading efivars via sysfs Thread-Index: ZwtG1mjZkaktWXHopN/M4SFWBKQyCQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Ard! > > Reported-by: Bob Sanders and the LTP testsuite > > Link: > > https://lore.kernel.org/linux-efi/20200303085528.27658-1-vdronov@redhat.com/T/#u > > For the future, please don't add these links. This one points to the > old version of the patch, not to this one. It will be added by the > tooling once the patch gets picked up. Aha. I was under an impression Links: are added manually by authors. My intention here was to point at the root message of the whole discussion, not at the patch. Anyway, thank you for the review and for bearing with me! Best regards, Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer