Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 5 Mar 2020 15:53:58 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 12/87] arm/ftrace: Fix BE text poking
Message-ID: <20200305145358.GC1950999@kroah.com>
References: <20200303174349.075101355@linuxfoundation.org>
 <20200303174350.172336594@linuxfoundation.org>
 <20200305134956.GD2367@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200305134956.GD2367@duo.ucw.cz>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 05, 2020 at 02:49:57PM +0100, Pavel Machek wrote:
> Hi!
> 
> > From: Peter Zijlstra <peterz@infradead.org>
> > 
> > [ Upstream commit be993e44badc448add6a18d6f12b20615692c4c3 ]
> > 
> > The __patch_text() function already applies __opcode_to_mem_*(), so
> > when __opcode_to_mem_*() is not the identity (BE*), it is applied
> > twice, wrecking the instruction.
> > 
> > Fixes: 42e51f187f86 ("arm/ftrace: Use __patch_text()")
> 
> I don't see 42e51f187f86 anywhere. Mainline contains
> 
> commit 5a735583b764750726621b0396d03e4782911b77
> Author: Peter Zijlstra <peterz@infradead.org>
> Date:   Tue Oct 15 21:07:35 2019 +0200
> 
>     arm/ftrace: Use __patch_text()
> 
> But that one is not present in 4.19, so perhaps we should not need
> this?

Good catch, I'll go drop this from everywhere.

I think Sasha has now fixed up his scripts to handle things when the
Fixes: tag does not point to a valid one.

thanks,

greg k-h