Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp5880073ybf; Thu, 5 Mar 2020 08:45:13 -0800 (PST) X-Google-Smtp-Source: ADFU+vvKH3+eprwNwgE/hdnAIlMsjFc3JxV9TMsIdTSb+AM1oCspENrB2GPlxYKZtXHTf1wFEOfj X-Received: by 2002:a9d:6058:: with SMTP id v24mr7059568otj.115.1583426713588; Thu, 05 Mar 2020 08:45:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583426713; cv=none; d=google.com; s=arc-20160816; b=BgBRAGWeVhL0d/8OR7ziNqKWfX37XH+QMkKg/h62nGZtxrv9ujE6p0VU4/rmGLVA4v YxOXUvLGyQs5HnwF1PbZ529XgnO2/0KBslKIlxTQgkDtGuK6FcE8qMkgRGxiqOJZumEt z5/FXgrXVLC2hDDIaDpMhrPoVdVysuQDsZTS5XH0HJUPJIiO8LAmQrBUxPcjIvJspwvw 1gLRMXzHJ7dTPsLF0lEbtDmWfuUS9oAmyqYlEnJyWtYZkGjbom8IzQlZE0pZMDAZFsj9 lrl6s1gqLMYpNrm3hJqm2vETbOaQEVoXRVrxiyY9TfPLScI8kPb8KMAweliIrj9atpkj dgeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=I9DAtl+FSyCFHYDQsK2Du0TBkiXUFV5Bx439VCb735M=; b=o4Kx5G+goEWb4PGQwG+JzNb5UO7Cwxx8z6jcRVZ52/m0UX6j1JMEeVJQ7L/WuaMZbN jXi/SGFlQlgmPKhAF2/sVKdtJTpalMcjlLS6wObP/q5OcUkivBDhFOsrOn23klYOly3z hvs9r0sPKNDaCIqj+a7zUO/d5B5hVwNKabZVzb4HdmmQghhLGUSVk5pJM/GKNily5aTA wY+qBA4Tp3YQ8MzmYj0jqXYxXxPCL2b55J0uTMP/UHjkMOymMNUSnrOb5G8GWuZ745G+ GVryHit7BiBCbvyobS4+WgARv0aMp78zCRcvPGwRA38Xc9XVo/oy8zBGwZgfjq7sWdhe gYiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DOWS+u5E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si3852947oth.136.2020.03.05.08.45.01; Thu, 05 Mar 2020 08:45:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DOWS+u5E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725993AbgCEQnJ (ORCPT + 99 others); Thu, 5 Mar 2020 11:43:09 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:39436 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725944AbgCEQnI (ORCPT ); Thu, 5 Mar 2020 11:43:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583426588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9DAtl+FSyCFHYDQsK2Du0TBkiXUFV5Bx439VCb735M=; b=DOWS+u5ECntN0+twRcEIDsyv/mqwuJy+PJ+IrxKEV1n/flHJChTe9kWVJWStljuJOwDZJe RTBAps2y8LEmDXbmHXVD1M3pb/+y3/mMclt97h0CHIGB3BXL1WHlcp4G4KLtxCfBVbGH+v K+CSAIM85rsCYA+TD7GbzrtNGQjiNc4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-092UltPZN9G7NekbN6qiFg-1; Thu, 05 Mar 2020 11:43:03 -0500 X-MC-Unique: 092UltPZN9G7NekbN6qiFg-1 Received: by mail-wr1-f69.google.com with SMTP id o9so2525396wrw.14 for ; Thu, 05 Mar 2020 08:43:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I9DAtl+FSyCFHYDQsK2Du0TBkiXUFV5Bx439VCb735M=; b=YUTK9ZIaxK2z/v5SApZsIPym9ip1AMZf/dxNnDD9VzuNaGb0X9RHtSJif4Rtz53aV/ d6yHp1qBAw207PEjO9JJKjH+Yiuoq9+dEdR6nj1ScPdxzCWpdwWtoJ+F4+F9pJHRV5b4 +JVg3CaoKE/gL8xc26nbeHPXbTBXXEhiBrO9A89bzvRW0ytgV6u0XT58KOh7eJtyhO0R Ld9LSnvJkV7Jzox6si5s1lVjtlDfCbT/dQwJWuC/0SVpPLcqYnA+Fs/e1GAjIaViDrw6 G2Lne8KOwlD4nF/VYkospwpf37t9LcTStLEbpOweEAHiACqiilQU85JJEbcVncBWOpuS nwHw== X-Gm-Message-State: ANhLgQ0dWwUFQgZ+VBNRZIilMDtVK8WPbrENWide14gI+ySWpuQ2uVdM I/yYOpCzNZ1EtrLz6gpLTrtodQQqpAYA9Xz5aYLfw8IYO0fh3QZEBajTkiQLlTXtZUEZkhl5N4B JGxWuO7YajLxgxqTwfvuSAG4a X-Received: by 2002:a5d:4004:: with SMTP id n4mr9624736wrp.48.1583426581723; Thu, 05 Mar 2020 08:43:01 -0800 (PST) X-Received: by 2002:a5d:4004:: with SMTP id n4mr9624713wrp.48.1583426581431; Thu, 05 Mar 2020 08:43:01 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:9def:34a0:b68d:9993? ([2001:b07:6468:f312:9def:34a0:b68d:9993]) by smtp.gmail.com with ESMTPSA id t1sm49390231wrs.41.2020.03.05.08.42.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2020 08:43:00 -0800 (PST) Subject: Re: [PATCH v2 0/7] KVM: x86: CPUID emulation and tracing fixes To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Pu Wen References: <20200305013437.8578-1-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <6071310f-dd4b-6a6d-5578-7b6f72a9b1be@redhat.com> Date: Thu, 5 Mar 2020 17:42:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200305013437.8578-1-sean.j.christopherson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/20 02:34, Sean Christopherson wrote: > > In theory, everything up to the refactoring is non-controversial, i.e. we > can bikeshed the refactoring without delaying the bug fixes. Even the refactoring itself is much less controversial. I queued everything, there's always time to unqueue. Paolo > v2: > - Use Jan's patch to fix the trace bug. [Everyone] > - Rework Hypervisor/Centaur handling so that only the Hypervisor > sub-ranges get the restrictive 0xffffff00 mask, and so that Centaur's > range only gets recognized when the guest vendor is Centaur. [Jim] > - Add the aforementioned bug fixes. > - Add a patch to do build time assertions on the vendor string, which > are hand coded u32s in the emulator (for direct comparison against > CPUID register output). > - Drop the patch to add CPUID.maxphyaddr emulator helper. [Paolo] > - Redo refactoring patches to land them after all the bug fixes > and to do the refactoring without any semantic changes in the > emulator.