Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp5914893ybf; Thu, 5 Mar 2020 09:23:13 -0800 (PST) X-Google-Smtp-Source: ADFU+vvwAmWIyUfp5ZU9Z1mSC5wk5xaAjNl7/PRZBLvH8SYUtjWecp3YRtc0+bkZZItGOXIlmiMg X-Received: by 2002:a05:6830:150:: with SMTP id j16mr7473212otp.301.1583428993628; Thu, 05 Mar 2020 09:23:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583428993; cv=none; d=google.com; s=arc-20160816; b=HnEZbXMIwjYkV+Ln3maRLvVCEhGqfsQUElCRelOHlxpOvZPXuBNK/cDh1T/nvoT4G4 yyvStyY3McmkRJip6B4/GQUhNkP8hJY1hYLlG6KZvRZnL6uBWVsQv9m+gx3C7qgc8f+L f0hbV683qNiqkMJgYPPLWXfxjHx6cugsChWUBmjZ4YcVzPa8zBTjbOXgcXbVG7Z1aEtR 5R3S7YCkarsz+YrNUeon7jgANVAWB8l2ky++Lj3bpIcfAHHDKZLeX4uXlFSmogiob834 lJuNgKS12glaCP4p7YfPYZ3Mj2twWBm7M6qNyRohE8gDo1/DdLit/iBeryp6nUu94UM7 eg6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rJ2XsCFG4dQfpvBPVPkeGn84h3ipD6sVwpf5m8g5r8k=; b=Y4LJpnUfaCQdBL7Z2l8iwMI4BmMzgfEDq3nhB9N+1WfCFZ3vbZeWY0PLHEgarZSBUu ccepyctaZz5M6M4p6vVIc+p5epi9Zh/Ix4CLO926kFFxcCT6UdPXInM4q/AA0HWlW1lG jWHQ8r+jZXfYgTUYJ3kWkA9IyZ9jc205EyoTJhB+k02z36bWXyONY/5QT7VSIFZhw17v 2rmspdtwruN7OMny2Bb4by4Grmh/Bq8UYjsa/vB7ScUUP1krqLJfPu9+t41Xz/Z1HAZh vnyurGnDVEUQAA6Icu2J3Icwtj8WFxGqvtfzRQcs4xzVVsV3a7jKucZQ2a9YAUZrL5ru AoDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ll8Qr1BN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h201si3723813oib.214.2020.03.05.09.23.01; Thu, 05 Mar 2020 09:23:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ll8Qr1BN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728044AbgCERVq (ORCPT + 99 others); Thu, 5 Mar 2020 12:21:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:40476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727659AbgCEROX (ORCPT ); Thu, 5 Mar 2020 12:14:23 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 572D321556; Thu, 5 Mar 2020 17:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428463; bh=YAFvu5ij+AyAowyPL31UII9ZhMcFpurD7oRq4jnXm+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ll8Qr1BNTqphKTjwZQSRjnbDtqdWVSGGUoCP529MupUk2uzd2qDCuvJ6voMDnFduL Rm0q+kaNV1GbRwhH2UD5MoVLqTOGHbE+77QsIf8U+dp/hBVmPP3Fmv8PACTo6134Vj 1hx0DCNugw8kuUhEvB01hPsN+Lef4AaeVoO1VbyQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mansour Behabadi , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 02/58] HID: apple: Add support for recent firmware on Magic Keyboards Date: Thu, 5 Mar 2020 12:13:23 -0500 Message-Id: <20200305171420.29595-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305171420.29595-1-sashal@kernel.org> References: <20200305171420.29595-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mansour Behabadi [ Upstream commit e433be929e63265b7412478eb7ff271467aee2d7 ] Magic Keyboards with more recent firmware (0x0100) report Fn key differently. Without this patch, Fn key may not behave as expected and may not be configurable via hid_apple fnmode module parameter. Signed-off-by: Mansour Behabadi Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-apple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index 6ac8becc2372e..d732d1d10cafb 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -340,7 +340,8 @@ static int apple_input_mapping(struct hid_device *hdev, struct hid_input *hi, unsigned long **bit, int *max) { if (usage->hid == (HID_UP_CUSTOM | 0x0003) || - usage->hid == (HID_UP_MSVENDOR | 0x0003)) { + usage->hid == (HID_UP_MSVENDOR | 0x0003) || + usage->hid == (HID_UP_HPVENDOR2 | 0x0003)) { /* The fn key on Apple USB keyboards */ set_bit(EV_REP, hi->input->evbit); hid_map_usage_clear(hi, usage, bit, max, EV_KEY, KEY_FN); -- 2.20.1