Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 05 Mar 2020 15:14:35 -0300
User-Agent: K-9 Mail for Android
In-Reply-To: <20200305153434.5r2jqsfxyrusrgwc@linux-p48b>
References: <20200305083714.9381-1-tommi.t.rantala@nokia.com> <20200305083714.9381-3-tommi.t.rantala@nokia.com> <20200305145149.GB7895@kernel.org> <20200305153434.5r2jqsfxyrusrgwc@linux-p48b>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 2/3] perf bench futex-wake: Restore thread count default to online CPU count
To:     Davidlohr Bueso <dave@stgolabs.net>
CC:     Tommi Rantala <tommi.t.rantala@nokia.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Darren Hart <dvhart@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org
From:   Arnaldo Melo <arnaldo.melo@gmail.com>
Message-ID: <64827405-D03D-4216-A3BD-8547AE42450B@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On March 5, 2020 12:34:34 PM GMT-03:00, Davidlohr Bueso <dave@stgolabs=2En=
et> wrote:
>On Thu, 05 Mar 2020, Arnaldo Carvalho de Melo wrote:
>
>>Em Thu, Mar 05, 2020 at 10:37:13AM +0200, Tommi Rantala escreveu:
>>> Since commit 3b2323c2c1c4 ("perf bench futex: Use cpumaps") the
>default
>>> number of threads the benchmark uses got changed from number of
>online
>>> CPUs to zero:
>>>
>>>   $ perf bench futex wake
>>>   # Running 'futex/wake' benchmark:
>>>   Run summary [PID 15930]: blocking on 0 threads (at [private] futex
>0x558b8ee4bfac), waking up 1 at a time=2E
>>>   [Run 1]: Wokeup 0 of 0 threads in 0=2E0000 ms
>>>   [=2E=2E=2E]
>>>   [Run 10]: Wokeup 0 of 0 threads in 0=2E0000 ms
>>>   Wokeup 0 of 0 threads in 0=2E0004 ms (+-40=2E82%)
>>>
>>> Restore the old behavior by grabbing the number of online CPUs via
>>> cpu->nr:
>>>
>>>   $ perf bench futex wake
>>>   # Running 'futex/wake' benchmark:
>>>   Run summary [PID 18356]: blocking on 8 threads (at [private] futex
>0xb3e62c), waking up 1 at a time=2E
>>>   [Run 1]: Wokeup 8 of 8 threads in 0=2E0260 ms
>>>   [=2E=2E=2E]
>>>   [Run 10]: Wokeup 8 of 8 threads in 0=2E0270 ms
>>>   Wokeup 8 of 8 threads in 0=2E0419 ms (+-24=2E35%)
>>>
>>> Fixes: 3b2323c2c1c4 ("perf bench futex: Use cpumaps")
>>
>>Thanks, tested and applied=2E
>
>Thanks!

Taking that as an Acked-by, ok?

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E