Date: Wed, 15 Feb 2006 18:43:45 +0800
From: Coywolf Qi Hunt <qiyong@fc-cn.com>
To: Avi Kivity <avi@argo.co.il>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] make sysctl_overcommit_memory enumeration sensible
Message-ID: <20060215104345.GA2879@localhost.localdomain>
References: <20060215085456.GA2481@localhost.localdomain> <20060215010559.55b55414.akpm@osdl.org> <20060215093136.GA2600@localhost.localdomain> <43F30346.1070802@argo.co.il>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43F30346.1070802@argo.co.il>
User-Agent: Mutt/1.5.11+cvs20060126
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1318
Lines: 47

On Wed, Feb 15, 2006 at 12:32:38PM +0200, Avi Kivity wrote:
> Coywolf Qi Hunt wrote:
> 
> >On Wed, Feb 15, 2006 at 01:05:59AM -0800, Andrew Morton wrote:
> > 
> >
> >>Coywolf Qi Hunt <qiyong@fc-cn.com> wrote:
> >>   
> >>
> >>>I see system admins often confused when they sysctl 
> >>>vm.overcommit_memory.
> >>>This patch makes overcommit_memory enumeration sensible.
> >>>
> >>>0 - no overcommit
> >>>1 - always overcommit
> >>>2 - heuristic overcommit (default)
> >>>
> >>>I don't feel this would break any userspace scripts.
> >>>     
> >>>
> >>eh?   If any such scripts exist, they'll break.
> >>
> >>Confused.
> >>   
> >>
> >
> >That's a corner case. Let'em break and fix.  Otherwise, users will
> >be confused. Even they get it right, after some weeks they'll have
> >to re-read the doc. A logical user interface is important to human.
> > 
> >
> 
> If I have
> 
>  vm.overcommit_memory = 2
> 
> in my /etc/sysctl.conf, its meaning silently changes. I'll know about 
> it during the next oomkiller pass.

Indeed. See, the breakage doesn't hurt.
-- 
Coywolf Qi Hunt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/