Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6245940ybf; Thu, 5 Mar 2020 16:28:10 -0800 (PST) X-Google-Smtp-Source: ADFU+vtFIcLMs6GNZr4gR6KznR77gZuovryixwjRwNNAZQmXKLfhB3dT7l4myfl9ea5kJN9w2EYx X-Received: by 2002:a05:6808:907:: with SMTP id w7mr785494oih.78.1583454490655; Thu, 05 Mar 2020 16:28:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583454490; cv=none; d=google.com; s=arc-20160816; b=QNGhu7ZtlzUEfPR5QeXAX831ZuPkvj0HGtzlj+Jl76c6oun26+B8epa5vXL1cNrB8/ xpqrYLnoPV161eWQWLFYVnL+EkRpTYBDGRxVdoubDDdIJeNb65lTaQDYeCtOr/sAr9ET Kz2UyxVRCKlW4XJi76tH50/usnFZ23n4IVc/gJKmSkXgQr+FtQtmH3viaEkwpKskbSd2 8X8j6sHG+TB72HqImAsA2LlywxXtHIVTQHJNO/wURzSnk5oqy13H21+7uj/nk9k13yFE 4TKK0w3IKXt/3eKng8qnhUhQMv5oNchYcJtml2NVnC550+61odcB5fXO3kvK4p+kXIDu Hruw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=wfmiFHBrDEs3sLx69uL5HVkwpXcEOPn5OAV9erWWdMo=; b=qLGSXJHbQ23MNZnftnpBA5SIjhYc2kqUlcwtunEb4XM+eeQolJ4QHB0hCfK06IVU2b e//ZmEnc9XE1mMlUzZLLCrIZiSKBbqM/0xLOiw1OdcX7qU0d+edQ/XNTzS8otaA8OjhN CfCO5HWoH3n6PvAkKwqwOcwAd4kcECv79+ANF2ypsy75U7ye87ScF5ZNJsMOdK19N5Gw m4y59z3oAzRJzrQdpHsyE+yzCRkxuc66HHlW4olzPxyzS967vRPMA99QeL+ltJUbumaa Kll9fggKeKnGkC2KZoqK1l0pDqlat9qepGZCQs7xmeC3OQbZB5zK3nJ4ELv6A0Vz+W3v yYQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a59si364148otb.8.2020.03.05.16.27.59; Thu, 05 Mar 2020 16:28:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbgCFA1g (ORCPT + 99 others); Thu, 5 Mar 2020 19:27:36 -0500 Received: from ozlabs.org ([203.11.71.1]:43561 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgCFA1f (ORCPT ); Thu, 5 Mar 2020 19:27:35 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 48YT396mMRz9sSR; Fri, 6 Mar 2020 11:27:33 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 0b1c524caaae2428b20e714297243e5551251eb5 In-Reply-To: <7b065c5be35726af4066cab238ee35cabceda1fa.1578558199.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Mike Rapoport From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] powerpc/32: refactor pmd_offset(pud_offset(pgd_offset... Message-Id: <48YT396mMRz9sSR@ozlabs.org> Date: Fri, 6 Mar 2020 11:27:33 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-01-09 at 08:25:25 UTC, Christophe Leroy wrote: > At several places pmd pointer is retrieved through the same action: > > pmd = pmd_offset(pud_offset(pgd_offset(mm, addr), addr), addr); > > or > > pmd = pmd_offset(pud_offset(pgd_offset_k(addr), addr), addr); > > Refactor this by implementing two helpers pmd_ptr() and pmd_ptr_k() > > This will help when adding the p4d level. > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/0b1c524caaae2428b20e714297243e5551251eb5 cheers