Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6248385ybf; Thu, 5 Mar 2020 16:31:23 -0800 (PST) X-Google-Smtp-Source: ADFU+vtCSBoS4f7pYYDyTRxC9xCshWxq9yj4qRdpcArCMt7/fJgVKcP4EEjOr4JZneoSj6f3GkEC X-Received: by 2002:aca:fc44:: with SMTP id a65mr744302oii.119.1583454683780; Thu, 05 Mar 2020 16:31:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583454683; cv=none; d=google.com; s=arc-20160816; b=kyOxrUv9m+LQIJdghz9PzrfLrNNpnnlWWJsMbXNWqsUsl80dDrHXngS3vs37m12Wp+ al5wS7lZIrbbCDp/vkf0zK7gr6YVlTZr2g02xxwDPhZqaWC7ghunrFylXhgJYkrkTA+G 9IMT71/bSCdDT7MCD0ZhTOhcxTgZNHoN7aZp9bYcKL6Dow4tHiBFp7g0jtpRRDfniZ+g kY+iAv6zrgtL+OKorVtuYkrGMFXyd3EVID17BEXLrRAm61qFXbmk1cQnv6oh0a88smhR U9/mahqR1CxMitSojPzL9JytvQVvds5Z4jJSh6RamCuNH/MS6p9hVFlGj9fo3tqe43LS l9Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=MM2TeeUzDkVH6Jaz3FdkOyWt+8KGCQgxym5sFOmIbNs=; b=KdIFLcmuNojkUYachozPfR6mJOOaUAaLdYBMHInjwDHrgBK3b+ANRtvN7l6cB4YUDQ rLGVI4lhWcH2BxKFUEDtTZ/h06i+uQBi1G8ivJthGpYKxcKaPlyQrc56qfcJLLsms9qu E8NlvMR/NcrOgU8zlRlXN7cyVGY1LgS5zn+iuPFBssoS0UUXQSCVHZYQfDoWs9Fm0WCI uerDo6USBVBxzaCvPsvSH7xgYMwNZWGUuAgybFl22Fn3LASjwTG5pr5/8NvKS1CURQ9L nYEKrr+eWNCJf4kc4ckTPy0wZ0rxsLbFmSbg0IIeD4lUp2vPwWjbncNmaITceh0vKK4e jR/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=GdI9kNUe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t12si358412oij.179.2020.03.05.16.31.11; Thu, 05 Mar 2020 16:31:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=GdI9kNUe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbgCFAao (ORCPT + 99 others); Thu, 5 Mar 2020 19:30:44 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:34288 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbgCFAao (ORCPT ); Thu, 5 Mar 2020 19:30:44 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0260TlG3004717; Thu, 5 Mar 2020 18:29:47 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1583454587; bh=MM2TeeUzDkVH6Jaz3FdkOyWt+8KGCQgxym5sFOmIbNs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=GdI9kNUeGDoFFbibWxDSVaNzrnMVGFT/xtGPZBrcWLPKJxInG3mPNOMNoigiSxOXv G/bKnj3DQmj+jGX9fFSWJbGDq7UsbYzvXp1CMKMoRINYiR2MKOg/wBxDVrT4zLgUS6 btNdiIem06vdcaTKvZhjlRymM0MrljUjKN3KarKw= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0260TlFw126586 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 5 Mar 2020 18:29:47 -0600 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 5 Mar 2020 18:29:47 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 5 Mar 2020 18:29:47 -0600 Received: from [128.247.81.254] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0260Tlg3085113; Thu, 5 Mar 2020 18:29:47 -0600 Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config To: Lee Jones , Arnd Bergmann CC: David Lechner , Tony Lindgren , Roger Quadros , , , References: <20200127231208.1443-1-s-anna@ti.com> <20200224100037.GK3494@dell> From: Suman Anna Message-ID: <5efbb3c4-044d-0a8e-630a-0dd559f20669@ti.com> Date: Thu, 5 Mar 2020 18:29:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20200224100037.GK3494@dell> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/20 4:00 AM, Lee Jones wrote: > On Mon, 27 Jan 2020, Suman Anna wrote: > >> The DT node full name is currently being used in regmap_config >> which in turn is used to create the regmap debugfs directories. >> This name however is not guaranteed to be unique and the regmap >> debugfs registration can fail in the cases where the syscon nodes >> have the same unit-address but are present in different DT node >> hierarchies. Replace this logic using the syscon reg resource >> address instead (inspired from logic used while creating platform >> devices) to ensure a unique name is given for each syscon. >> >> Signed-off-by: Suman Anna >> --- >> v2: Fix build warning reported by kbuild test bot >> v1: https://patchwork.kernel.org/patch/11346363/ >> >> drivers/mfd/syscon.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > Waiting for Arnd to review. > Hi Arnd, Gentle ping, any comments? regards Suman