Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6288995ybf; Thu, 5 Mar 2020 17:21:49 -0800 (PST) X-Google-Smtp-Source: ADFU+vvFvXWj/RfgrkLEw9Kowl3J6xpdUQQxofR6VggrfoImEq2ztDQSq7+x2FvqLv/Map7hXEZn X-Received: by 2002:aca:4944:: with SMTP id w65mr925279oia.66.1583457709695; Thu, 05 Mar 2020 17:21:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583457709; cv=none; d=google.com; s=arc-20160816; b=e04QaLgkbTH/lM+p665smQ4f/blq/YvMSet5NorDX8uqNtHzrEHVc0jgjKJLXdaIRl fr68GpnSng7WGhrIarkPdeM3C0av9BjlMLZ+OavAFHxy8R0Xi3RJgABC3M+3JpocJwTx dL0+sIIlpBvDVcn0ACqFceOz3SuymFR6/CUyQ++TxQ+uH4VumAC82YWEPUMfUHzuSfat 29LvJ3aPfH78SQoplEqpJKLYnRGfFd8TrBsq0CCq1E/V8VvY4hpXHffDRXBXFByPrLMG QF/bQNAth3I+eS3OuEjCqS6KGmKfbm0KDl2bnczVxwj3PNO9qDhXt7TlE3GrKmUzAEjw u3aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=I13llcu/Wrs6zMSmAU8dxK9xRlce4dAdS7DYx5+VY1A=; b=K+YuB6glYNwsvbv5PmPo7WmjwHAyQB4JHucQFcCSbLQ2GAuI1BQVRpljGihIaHZSIL xrqOOabcTuaIAjI/2pFPum/jW0vc5Sjdm+4HW4o3AjnCXSg/NaJC6O8Q5x1fFYfCEhEZ vdKlPOZ3bxLN9uaCKNKqvdpD/fRD2A3LY0H3vCCo+Bt3XVPUh56w5rIPez2fZPXxG7Qj 9AHrQCFX17qwaUbHa1PtFbcafjnG2zu67WJURDehJXgTUDitNI3I8ILbi0U02GPw+jeB IqTysb5JIvoMiMoUY/ShKSI55VBmsuD7OW51I3qu8vE1A4uqA/otUFnzy+PGRXDf+EqX PbkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v19si435844otn.100.2020.03.05.17.21.37; Thu, 05 Mar 2020 17:21:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726533AbgCFBTq (ORCPT + 99 others); Thu, 5 Mar 2020 20:19:46 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:11174 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726162AbgCFBTq (ORCPT ); Thu, 5 Mar 2020 20:19:46 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 77563EC8DC063C1F3480; Fri, 6 Mar 2020 09:19:43 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Mar 2020 09:19:41 +0800 Subject: Re: [PATCH V2 2/2] f2fs: Add a new CP flag to help fsck fix resize SPO issues To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1583245766-3351-1-git-send-email-stummala@codeaurora.org> <1583245766-3351-2-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Fri, 6 Mar 2020 09:19:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1583245766-3351-2-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/3/3 22:29, Sahitya Tummala wrote: > Add and set a new CP flag CP_RESIZEFS_FLAG during > online resize FS to help fsck fix the metadata mismatch > that may happen due to SPO during resize, where SB > got updated but CP data couldn't be written yet. > > fsck errors - > Info: CKPT version = 6ed7bccb > Wrong user_block_count(2233856) > [f2fs_do_mount:3365] Checkpoint is polluted I'm not against this patch, however without this change, could fsck have any chance to repair old image? > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu