Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6455963ybf; Thu, 5 Mar 2020 21:21:48 -0800 (PST) X-Google-Smtp-Source: ADFU+vvGscI/ibtHRXAORaGE0Q2lKaRhnBz9ctO4uqrXCe5+UEKzqKxEycmuMcr+fTUlVxfrsc7O X-Received: by 2002:a9d:6e87:: with SMTP id a7mr1134844otr.352.1583472108084; Thu, 05 Mar 2020 21:21:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583472108; cv=none; d=google.com; s=arc-20160816; b=s80mrc52vFNE329rn3N15UYmbYs49eGTiObqE5GkbBbDZy7kmzWbJzYM2jpWsDyYg0 1gcLlFGjh9Ebs+yHLaZyur6N9ceaf7jUlHLL2H0PcN2jOL46SPLh1QRNcFLGRZIMms+Q ONqRo5Fwd2Fjlh34esEcMBVTA9QmN04KuDVJVHgZpdulYDFR+cQoxi9waSGEEksVVRGH Xy1cpKaPXkN9M0mTn+wmhWPif0bkzwucE8Xiy2DlBtgvgHYN8wHucS2KV0/xmc8F84fh vklO0hoNbrWJwl7MWkpzXtXGhituRcSV6VgTfY7u0A8KT6kLjDLPrmGepfGObMWhtLYi 231A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from; bh=RqoVpJn0Ly1KhpsgSWyoMjyjfxwWkBbt5lmP1xUGQcg=; b=etmcPyo41LONmgtbiJFkGL3ItbigPBrtKlr2xJ5jGnhLrKmiP9vDlH1AYNqB8bA4TA qENjJbtJe8N1+hpsIc+MibfnF4aoLLM0lAOafU/IqPnIa+lswvzPZXr0gPTKhY3MmFGp h2DK3Bd6mcUhCh+1Pg7EC3lwzACCIF+xIqNU8w9oVab03Gulkf4NrN6ozvwdd7J3chfF oHo/gwMPcucHKtk7WMlM1Nr7bnVys9sujC24NJ1kQG1mfT+nKzfpUz0zmT9MIOkR7yyC 3Jg2XD/c4oMRDD9UzxiMTT6TDCJCGQDQ11nnq5tZH2kmZ+sIRtItDb2bElfAaHqO/7GU fWGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si785331oie.138.2020.03.05.21.21.36; Thu, 05 Mar 2020 21:21:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725972AbgCFFVT (ORCPT + 99 others); Fri, 6 Mar 2020 00:21:19 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:56224 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725784AbgCFFVS (ORCPT ); Fri, 6 Mar 2020 00:21:18 -0500 Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jA5QD-0006OO-JB; Thu, 05 Mar 2020 22:21:17 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jA5QC-0004ty-VK; Thu, 05 Mar 2020 22:21:17 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Bernd Edlinger Cc: Christian Brauner , Kees Cook , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra \(Intel\)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" , "linux-mm\@kvack.org" , "stable\@vger.kernel.org" , "linux-api\@vger.kernel.org" References: <87v9nmjulm.fsf@x220.int.ebiederm.org> <202003021531.C77EF10@keescook> <20200303085802.eqn6jbhwxtmz4j2x@wittgenstein> <87v9nlii0b.fsf@x220.int.ebiederm.org> <87a74xi4kz.fsf@x220.int.ebiederm.org> <87r1y8dqqz.fsf@x220.int.ebiederm.org> <87tv32cxmf.fsf_-_@x220.int.ebiederm.org> <87o8tacxl3.fsf_-_@x220.int.ebiederm.org> Date: Thu, 05 Mar 2020 23:19:03 -0600 In-Reply-To: (Bernd Edlinger's message of "Thu, 5 Mar 2020 22:34:07 +0000") Message-ID: <87blpaawmw.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jA5QC-0004ty-VK;;;mid=<87blpaawmw.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18xi+IMFulUpbVXvPZlB47PFQOqvybEWgY= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa02.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,XMNoVowels autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4846] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Bernd Edlinger X-Spam-Relay-Country: X-Spam-Timing: total 231 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 4.6 (2.0%), b_tie_ro: 3.5 (1.5%), parse: 1.21 (0.5%), extract_message_metadata: 11 (4.6%), get_uri_detail_list: 0.55 (0.2%), tests_pri_-1000: 14 (6.0%), tests_pri_-950: 0.96 (0.4%), tests_pri_-900: 0.86 (0.4%), tests_pri_-90: 21 (9.2%), check_bayes: 20 (8.6%), b_tokenize: 7 (3.1%), b_tok_get_all: 6 (2.6%), b_comp_prob: 1.32 (0.6%), b_tok_touch_all: 3.4 (1.5%), b_finish: 0.67 (0.3%), tests_pri_0: 165 (71.6%), check_dkim_signature: 0.38 (0.2%), check_dkim_adsp: 2.5 (1.1%), poll_dns_idle: 1.14 (0.5%), tests_pri_10: 2.6 (1.1%), tests_pri_500: 6 (2.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 1/2] exec: Properly mark the point of no return X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bernd Edlinger writes: > On 3/5/20 10:15 PM, Eric W. Biederman wrote: >> @@ -1266,7 +1267,7 @@ int flush_old_exec(struct linux_binprm * bprm) >> * Make sure we have a private signal table and that >> * we are unassociated from the previous thread group. >> */ >> - retval = de_thread(current); >> + retval = de_thread(bprm, current); > > can we get rid of passing current as parameter here? With a separate patch. It makes the patch less clear if I make that change in this one. Eric