Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6581051ybf; Fri, 6 Mar 2020 00:16:12 -0800 (PST) X-Google-Smtp-Source: ADFU+vtCCp6IPBJYnfLfJYSQSeuIj0OGWC7zgR3VzrefS02rKttdRlKp6rkKVDQ+aOVtsnJn1szM X-Received: by 2002:a05:6830:19ec:: with SMTP id t12mr1574074ott.161.1583482572189; Fri, 06 Mar 2020 00:16:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583482572; cv=none; d=google.com; s=arc-20160816; b=LZxp4WNe3MJHEw1imXAY0DCdeqfOO/I0FKhU/HwcsYJ/4QJPdjC7WutXvNYksSsy3s KO4UQhtctnIFVc2kPrGoTY+2cbBSybSbU9nLlhIfA4QBCAdYR2CWP0TPtil8QZCHDEDv s125xAsjcaejiC779/N9j4IYvRia3J9lcwFRFLEpe9bOncKsCACPo5ctHEnByrWP6103 KDDhhwgkYMiCv5dC+fqblPunCpXl7O1esz8v+tcbLJQ8yvAxh2QrtH5febXFgUPUZD+v 9b60DVZy7b8586r+ES5sZc4NM+cFLmVH5akimGl1HDmujo13QIMMgO7U/VnPsVNlCX8z 0q8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to:date :references:subject:cc:to:from; bh=dVWRePtSMWd8hSXocCYP0lKOzYKrZt7Yr9tgFXJmLCg=; b=vuT7EnnFps7xqgYAh8qZhrW2Ci4/gt/h5buY/qO9b3Mm9zU52HEbyXUtkpBnKX2h91 cXVBf1TqVJndf9RKA+r2f50M6jfNigO+brpLG2lpQP5hXjortCXCOj3OLBUURcEIdyiL sLvxTKHHEzmLFJB38AqOStiiEY/dlL8D77ArOlZK/L4x2AaAhfG9zRg8kz4R3SDAfdEG qASfpZRzX4vdi1/qOTMG4ttME5psGnzdgeLP9Gw2YBW1IXTz+r+vKFkIKJCEetaNkJAx Dfcw9LFtzY1S68Rs5OebcObiWLrDrvcxpa6z+WvXEn6cRqImNY/I9aPr6uJOyK3QhOfN YJ/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1si1009654otq.81.2020.03.06.00.15.58; Fri, 06 Mar 2020 00:16:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726129AbgCFIPk (ORCPT + 99 others); Fri, 6 Mar 2020 03:15:40 -0500 Received: from albireo.enyo.de ([37.24.231.21]:54478 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbgCFIPk (ORCPT ); Fri, 6 Mar 2020 03:15:40 -0500 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jA88n-0008VD-Dn; Fri, 06 Mar 2020 08:15:29 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1jA87C-0001li-5M; Fri, 06 Mar 2020 09:13:50 +0100 From: Florian Weimer To: YunQiang Su Cc: torvalds@linux-foundation.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, libc-alpha@sourceware.org, Laurent Vivier Subject: Re: [PATCH] binfmt_misc: pass binfmt_misc P flag to the interpreter References: <20200306080905.173466-1-syq@debian.org> Date: Fri, 06 Mar 2020 09:13:50 +0100 In-Reply-To: <20200306080905.173466-1-syq@debian.org> (YunQiang Su's message of "Fri, 6 Mar 2020 16:09:05 +0800") Message-ID: <87r1y53npd.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * YunQiang Su: > + if (bprm->interp_flags & BINPRM_FLAGS_PRESERVE_ARGV0) > + flags |= AT_FLAGS_PRESERVE_ARGV0; > + NEW_AUX_ENT(AT_FLAGS, flags); Is it necessary to reuse AT_FLAGS? I think it's cleaner to define a separate AT_ tag dedicated to binfmt_misc.