Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v1 0/2] x86/Kconfig: modify X86_UMIP depends on CPUs
To:     Sean Christopherson <sean.j.christopherson@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <hpa@zytor.com>, <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <DavidWang@zhaoxin.com>, <CooperYan@zhaoxin.com>,
        <QiyuanWang@zhaoxin.com>, <HerryYang@zhaoxin.com>
References: <1583390951-4103-1-git-send-email-TonyWWang-oc@zhaoxin.com>
 <20200305155115.GC11500@linux.intel.com>
From:   Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
Message-ID: <35a6558c-1f92-d921-6998-ce639a8edaf6@zhaoxin.com>
Date:   Fri, 6 Mar 2020 17:12:50 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200305155115.GC11500@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 05/03/2020 23:51, Sean Christopherson wrote:
> On Thu, Mar 05, 2020 at 02:49:09PM +0800, Tony W Wang-oc wrote:
>> CONFIG_X86_UMIP is generic since commit b971880fe79f (x86/Kconfig:
>> Rename UMIP config parameter).
>>
>> Some Centaur family 7 CPUs and Zhaoxin family 7 CPUs support the UMIP
>> feature. So, modify X86_UMIP to cover these CPUs too.
> 
> That leaves UMC_32, TRANSMETA_32 and CYRIX_32 as the last CPU_SUP types
> that don't support UMIP.  Maybe it's time to remove the CPU_SUP checks
> altogether, same as X86_SMAP?

While the UMIP is a generic X86 CPU feature, I think this way is better.

Sincerely
TonyWWang-oc
> 
>> Tony W Wang-oc (2):
>>   x86/Kconfig: Make X86_UMIP to cover Centaur CPUs
>>   x86/Kconfig: Make X86_UMIP to cover Zhaoxin CPUs
>>
>>  arch/x86/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> -- 
>> 2.7.4
>>
> .
>