Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6714490ybf; Fri, 6 Mar 2020 03:10:12 -0800 (PST) X-Google-Smtp-Source: ADFU+vvJyQGBRnFIJR2z9np0RTpplbTFT70fI4YZv3VsEfJeGsPuEaypuO5lV0iHD+yeg0LS9l4h X-Received: by 2002:a05:6830:1112:: with SMTP id w18mr2065955otq.185.1583493011938; Fri, 06 Mar 2020 03:10:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583493011; cv=none; d=google.com; s=arc-20160816; b=E05PMDHXefHLXZ5dl7UkyH1ExNP9ZEihrb6WOGL9Y9T+u/t6AgSNxmfIwlX8iF5EKU UmKxxSNI2/62T6fQok5Rw8Fl70+m7w20GJ1NpGJPBvFTTWkap3KbID4Tx6pbKAs4haL2 i1h1z4EW2DeCqH7x+xdTrieY9z4xH38Ew7dgcYcxNz44NOhN6HEdEYwya5ode8l8SNRj eH0lOeeGSkj66htO+SnYvSbpPK7JURZI3xTxANXKbzYXaxdwFrMOAOhugYtfX5yt2BEx DtnEs+oB2/FgJ+C8WkI6haUUV0ypep2ooVqDKBPJ1UK/E9ii5LwuCVKr0CjOQGP3uyh7 sRew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:dkim-signature; bh=7sHD6CjQ22ZwQRigFX726J4p2bWMAR4ljphlUJcoYAY=; b=cZUvQ3a3Nk0TEuUVojiq2qxQV+RE9k0mA/OesXPLLGcP2SOEiPlkQHvkpr1abK9gWi K5yNwFZbLlcDu7MtzNAZbVllDLdr2CvaHkLz5PPnT8T1sS8oUt9/ePUtps2n5Y6wH0BI nl0xIx2r57BK0lc/9i2K0Pk/NEOV9JrEs/T1bVpOojA4dREeFlHwGQD1sshjYiHeaeLD hueGmqCZDuqc1rfDM16Xk/BRWIIa22cLWeexww6mF7v7pwK3q5WT99LTvyPyD82xfr8l Z965Rhwt/8ZqG8Gbcza60853VA2DX9URLl1YeLb/5X1T8fY4WpQR8RRhcwifRE/WZQdo 0Afw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Po4eTrKT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f20si1232291oti.224.2020.03.06.03.10.00; Fri, 06 Mar 2020 03:10:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Po4eTrKT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbgCFLIW (ORCPT + 99 others); Fri, 6 Mar 2020 06:08:22 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:50617 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgCFLIW (ORCPT ); Fri, 6 Mar 2020 06:08:22 -0500 Received: by mail-wm1-f65.google.com with SMTP id a5so1940946wmb.0 for ; Fri, 06 Mar 2020 03:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=7sHD6CjQ22ZwQRigFX726J4p2bWMAR4ljphlUJcoYAY=; b=Po4eTrKTy/hIT89j6SjWAKG3l7sTUwlpHMXmqtkp7pbCRmWtb4lPeWcxoj801ag9Ep fHDomNyvJH3mgX40pqhUqCbNwxt0fsj8lTv085lm/A8Ex981ERxWeUd/rMFLwvPwgKQl FdFaU5tzI/bMdYNhm7EZq1JnhHpniL+pxbrXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=7sHD6CjQ22ZwQRigFX726J4p2bWMAR4ljphlUJcoYAY=; b=bane30A3By73PDGaz9PFoiSilQbGV/z46G6w03LEI4ogdLuvHQuq/yMoKnsaHERwgZ YuvQ/UVYtxAw3xndlfZSY/69n8NtCar/54SUpXOxE1RTz4FK+OzXSa5kaCREuKTLDo5P 9+Q0os678rhmh4mz9BpuYOXPOXyC8GoaYeNAELtNbePhxUFBsNetYEdXUzsXUxbHnSZ7 fzFewYUBzaWxw6kHLudgmvEfFctrsc4Lw/EvlLoZTrHSUb7ZnPbX9y6Wyq+EUs0/nIks rEHqc+q/yKVeCqDbYZZ1++mqBmSGfYhXwuy53Eu1/B/rkRjBNptkB23Gh3ME231+fjk2 uNCg== X-Gm-Message-State: ANhLgQ3U6NdoAfDmr9ysEcfW+33Q7Do0XJaJJ2WOrbN+Bwcne2108Gki nNcgpVyaUclbz/eV3gajXrWYAA== X-Received: by 2002:a1c:f214:: with SMTP id s20mr3328009wmc.57.1583492900393; Fri, 06 Mar 2020 03:08:20 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j20sm13605554wmj.46.2020.03.06.03.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 03:08:19 -0800 (PST) Date: Fri, 6 Mar 2020 12:08:17 +0100 From: Daniel Vetter To: Benjamin Gaignard Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm: context: Clean up documentation Message-ID: <20200306110817.GZ2363188@phenom.ffwll.local> Mail-Followup-To: Benjamin Gaignard , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20200306102937.4932-1-benjamin.gaignard@st.com> <20200306102937.4932-4-benjamin.gaignard@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200306102937.4932-4-benjamin.gaignard@st.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2020 at 11:29:37AM +0100, Benjamin Gaignard wrote: > Fix kernel doc comments to avoid warnings when compiling with W=1. > > Signed-off-by: Benjamin Gaignard > --- > version 2: > - Since it is legacy interface do not fix the description but > replace /** by /* to remove kerneldoc validation warnings On the entire series: Acked-by: Daniel Vetter > > drivers/gpu/drm/drm_context.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/drm_context.c b/drivers/gpu/drm/drm_context.c > index 1f802d8e5681..c99be950bf17 100644 > --- a/drivers/gpu/drm/drm_context.c > +++ b/drivers/gpu/drm/drm_context.c > @@ -47,7 +47,7 @@ struct drm_ctx_list { > /** \name Context bitmap support */ > /*@{*/ > > -/** > +/* > * Free a handle from the context bitmap. > * > * \param dev DRM device. > @@ -68,7 +68,7 @@ void drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle) > mutex_unlock(&dev->struct_mutex); > } > > -/** > +/* > * Context bitmap allocation. > * > * \param dev DRM device. > @@ -88,7 +88,7 @@ static int drm_legacy_ctxbitmap_next(struct drm_device * dev) > return ret; > } > > -/** > +/* > * Context bitmap initialization. > * > * \param dev DRM device. > @@ -104,7 +104,7 @@ void drm_legacy_ctxbitmap_init(struct drm_device * dev) > idr_init(&dev->ctx_idr); > } > > -/** > +/* > * Context bitmap cleanup. > * > * \param dev DRM device. > @@ -163,7 +163,7 @@ void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file) > /** \name Per Context SAREA Support */ > /*@{*/ > > -/** > +/* > * Get per-context SAREA. > * > * \param inode device inode. > @@ -211,7 +211,7 @@ int drm_legacy_getsareactx(struct drm_device *dev, void *data, > return 0; > } > > -/** > +/* > * Set per-context SAREA. > * > * \param inode device inode. > @@ -263,7 +263,7 @@ int drm_legacy_setsareactx(struct drm_device *dev, void *data, > /** \name The actual DRM context handling routines */ > /*@{*/ > > -/** > +/* > * Switch context. > * > * \param dev DRM device. > @@ -290,7 +290,7 @@ static int drm_context_switch(struct drm_device * dev, int old, int new) > return 0; > } > > -/** > +/* > * Complete context switch. > * > * \param dev DRM device. > @@ -318,7 +318,7 @@ static int drm_context_switch_complete(struct drm_device *dev, > return 0; > } > > -/** > +/* > * Reserve contexts. > * > * \param inode device inode. > @@ -351,7 +351,7 @@ int drm_legacy_resctx(struct drm_device *dev, void *data, > return 0; > } > > -/** > +/* > * Add context. > * > * \param inode device inode. > @@ -404,7 +404,7 @@ int drm_legacy_addctx(struct drm_device *dev, void *data, > return 0; > } > > -/** > +/* > * Get context. > * > * \param inode device inode. > @@ -428,7 +428,7 @@ int drm_legacy_getctx(struct drm_device *dev, void *data, > return 0; > } > > -/** > +/* > * Switch context. > * > * \param inode device inode. > @@ -452,7 +452,7 @@ int drm_legacy_switchctx(struct drm_device *dev, void *data, > return drm_context_switch(dev, dev->last_context, ctx->handle); > } > > -/** > +/* > * New context. > * > * \param inode device inode. > @@ -478,7 +478,7 @@ int drm_legacy_newctx(struct drm_device *dev, void *data, > return 0; > } > > -/** > +/* > * Remove context. > * > * \param inode device inode. > -- > 2.15.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch