Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946017AbWBOQst (ORCPT ); Wed, 15 Feb 2006 11:48:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946021AbWBOQst (ORCPT ); Wed, 15 Feb 2006 11:48:49 -0500 Received: from [194.90.237.34] ([194.90.237.34]:10846 "EHLO mtlexch01.mtl.com") by vger.kernel.org with ESMTP id S1946017AbWBOQsr (ORCPT ); Wed, 15 Feb 2006 11:48:47 -0500 Date: Wed, 15 Feb 2006 18:50:16 +0200 From: "Michael S. Tsirkin" To: Badari Pulavarty Cc: linux-arch@vger.kernel.org, Linux Kernel Mailing List , Nick Piggin , Andrew Morton , Roland Dreier , Hugh Dickins , Linus Torvalds , Gleb Natapov , Benjamin Herrenschmidt , openib-general@openib.org, Petr Vandrovec , Matthew Wilcox Subject: Re: [PATCH] add asm-generic/mman.h Message-ID: <20060215165016.GD12974@mellanox.co.il> Reply-To: "Michael S. Tsirkin" References: <20060215151649.GA12090@mellanox.co.il> <1140019088.21448.3.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1140019088.21448.3.camel@dyn9047017100.beaverton.ibm.com> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 15 Feb 2006 16:50:42.0046 (UTC) FILETIME=[F4F9E1E0:01C6324F] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1576 Lines: 45 Quoting r. Badari Pulavarty : > Subject: Re: [PATCH] add asm-generic/mman.h > > On Wed, 2006-02-15 at 17:16 +0200, Michael S. Tsirkin wrote: > > How does the following look (against gc3-git)? > > I tried to do the same earlier (while doing MADV_REMOVE) and got > ugly (I was trying to completely get rid of asm-specific ones), > so I gave up. > > Anyway, > > > > Index: linux-2.6.16-rc3/include/asm-generic/mman.h > > =================================================================== > > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > > +++ linux-2.6.16-rc3/include/asm-generic/mman.h 2006-02-15 19:59:41.000000000 +0200 > .. > > +#define MS_ASYNC 1 /* sync memory asynchronously */ > > +#define MS_SYNC 2 /* synchronous memory sync */ > > +#define MS_INVALIDATE 4 /* invalidate the caches */ > > Shouldn't this be ? > > +#define MS_ASYNC 1 /* sync memory asynchronously */ > +#define MS_INVALIDATE 2 /* invalidate the caches */ > +#define MS_SYNC 4 /* synchronous memory sync */ > > Thanks, > Badari > Note that this only looks misaligned in the patch. When you apply, + disappears and numbers get aligned. Other stuff in asm-xx/mman.h is aligned by tabs and not by spaces, so why should these options be aligned by spaces? -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/