Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946048AbWBOR2x (ORCPT ); Wed, 15 Feb 2006 12:28:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946045AbWBOR2x (ORCPT ); Wed, 15 Feb 2006 12:28:53 -0500 Received: from smtp.osdl.org ([65.172.181.4]:50853 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1946044AbWBOR2w (ORCPT ); Wed, 15 Feb 2006 12:28:52 -0500 Date: Wed, 15 Feb 2006 09:28:30 -0800 (PST) From: Linus Torvalds To: "Michael S. Tsirkin" cc: Badari Pulavarty , linux-arch@vger.kernel.org, Linux Kernel Mailing List , Nick Piggin , Andrew Morton , Roland Dreier , Hugh Dickins , Gleb Natapov , Benjamin Herrenschmidt , openib-general@openib.org, Petr Vandrovec , Matthew Wilcox Subject: Re: [PATCH] add asm-generic/mman.h In-Reply-To: <20060215170935.GE12974@mellanox.co.il> Message-ID: References: <20060215151649.GA12090@mellanox.co.il> <1140019088.21448.3.camel@dyn9047017100.beaverton.ibm.com> <20060215165016.GD12974@mellanox.co.il> <1140022377.21448.6.camel@dyn9047017100.beaverton.ibm.com> <20060215170935.GE12974@mellanox.co.il> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 35 On Wed, 15 Feb 2006, Michael S. Tsirkin wrote: > > Other numbers look right, dont they? Suggestion: for each macro name, do grep "macroname" patch and if you see anything that looks even half-way suspicious, check it. Here's a pipeline from hell which shows that you broke at least MADV_REMOVE (which has values 5-9 depending on architecture). sed -n '/^[-+].*define[ ]*/ { s/.*define[ ]*\([A-Za-z_0-9]*\).*/\1/ ; p}' patch | sort -u | while read i do echo $i: grep "^[-+].*$i" patch done | less -S Rule #1: use tools instead of eyeballs whenever you possibly can. Humans are bad at noticing changes like this. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/