Message-ID: <43F368FA.7000000@grupopie.com>
Date: Wed, 15 Feb 2006 17:46:34 +0000
From: Paulo Marques <pmarques@grupopie.com>
Organization: Grupo PIE
User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050716)
MIME-Version: 1.0
To: Chuck Ebbert <76306.1226@compuserve.com>
CC: linux-kernel <linux-kernel@vger.kernel.org>,
       Linus Torvalds <torvalds@osdl.org>
Subject: Re: Trap flag handling change in 2.6.10-bk5 broke Kylix  debugger
References: <200602142220_MC3-1-B866-DF84@compuserve.com>
In-Reply-To: <200602142220_MC3-1-B866-DF84@compuserve.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1331
Lines: 36

Chuck Ebbert wrote:
> On Tue, 14 Feb 2006 at 20:21:08 +0000, Paulo Marques wrote:
> 
>>>+                   regs->eflags &= ~TF_MASK;
>>>+                   tsk->ptrace &= ~PT_DTRACE;
>>>+                   if (!tsk->ptrace & PT_DTRACE)
> 
>                             ^^^^^^^^^^^^^^^^^^^^^^^^
>   Looks like this is always true because that bit was cleared one line above.
> Maybe it should be testing PT_DTRACED instead?  And it's missing parens too,
> so try:
>                         if (!(tsk->ptrace & PT_DTRACED))

Yes, this does look funny :P

However, this is the piece of code that I don't put in in order to make 
the debugger work, and it doesn't exist on the vanilla 2.6.16-rc kernel 
anymore.

What I did try to do was to add the:

-           if ((tsk->ptrace & (PT_DTRACE|PT_PTRACED)) == PT_DTRACE)
-                   goto clear_TF;

condition to the 2.6.16-rc kernel, but that didn't work anyway :(

-- 
Paulo Marques - www.grupopie.com

Pointy-Haired Boss: I don't see anything that could stand in our way.
            Dilbert: Sanity? Reality? The laws of physics?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/