Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp7046498ybf; Fri, 6 Mar 2020 09:19:18 -0800 (PST) X-Google-Smtp-Source: ADFU+vttRWInX/3jMkuyl4BNX0TiiJik4X/ACpfDFK3HpUWyWgI6CLUEpaPCL9kCYGp2QZEys6w8 X-Received: by 2002:aca:5109:: with SMTP id f9mr2326192oib.14.1583515158188; Fri, 06 Mar 2020 09:19:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583515158; cv=none; d=google.com; s=arc-20160816; b=xGt1DMHkD0wtQBxXj3eDIoiHon1BjuT1r5+J+/OgvtFYsFZKuqCYiB8G1k5val575b bwnDEu66dujbque3cOhL95ZX9AYeFFmQ40JVoLF6v52qxHwi+5vV2YlLXTP5Lwz/HNek 8eLR9dc5pRuoevMXc41w4RAZo1QGAOlzNSv1a3YeLHuNYkzi4S97ocfG5pumw73TkVxL tdPjEmi0zo+V9a+hxAaL+IU/k/CMiYL9LtFQ1Y60ocA88/U8hsbk3oCpalvmkHrZ70RO kddFAIlLYhFI2777PQI8g9OMWaeKG1uSX95kmKhzci8kidjCxAK8XGvZ6/XdvGw+OLhL 7MvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from; bh=YNJRNs014npw6vLEChJdV9MmuAPIfdm08NKR8BZf854=; b=JBXoBXbauA2eYRNV54s4bCa2OlPCuxo1tPe/OMgYWSxj4L71duCZ5r3fHJbsI5b17r 0Fho+IfovMRzCaofM+6D9IMmLkvx6YGDnj+eki0Im6GVxEHlFQg2rmfRFw8pjYh30V+j f4Mtoh2kwjWyNY1VQfpw2jqf2xzzw+m+sNTbKwtm6YxQMe2e5Fgt7dOUUXWxzbaKeHFT kiSzLOz3gbrYry1O0BLRsgqxrYlgptD5J5q3D3Rb03L500WwVO0G+iN5COdmF0ZTKZxo s0S3eoY9eTActINZkJF55plhnXwQbqikF5aTKW3EAH1Yo3/vyu22u1Uldj+L2SUf3GNN O+xQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si12853oij.64.2020.03.06.09.19.05; Fri, 06 Mar 2020 09:19:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726932AbgCFRSU (ORCPT + 99 others); Fri, 6 Mar 2020 12:18:20 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:56238 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbgCFRSU (ORCPT ); Fri, 6 Mar 2020 12:18:20 -0500 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jAGc4-0001Lk-Ci; Fri, 06 Mar 2020 10:18:16 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jAGc3-0002xI-5G; Fri, 06 Mar 2020 10:18:15 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Bernd Edlinger Cc: Christian Brauner , Kees Cook , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra \(Intel\)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" , "linux-mm\@kvack.org" , "stable\@vger.kernel.org" , "linux-api\@vger.kernel.org" References: <202003021531.C77EF10@keescook> <20200303085802.eqn6jbhwxtmz4j2x@wittgenstein> <87v9nlii0b.fsf@x220.int.ebiederm.org> <87a74xi4kz.fsf@x220.int.ebiederm.org> <87r1y8dqqz.fsf@x220.int.ebiederm.org> <87tv32cxmf.fsf_-_@x220.int.ebiederm.org> <87o8tacxl3.fsf_-_@x220.int.ebiederm.org> <87pndqax3j.fsf@x220.int.ebiederm.org> Date: Fri, 06 Mar 2020 11:16:00 -0600 In-Reply-To: (Bernd Edlinger's message of "Fri, 6 Mar 2020 16:26:34 +0000") Message-ID: <87v9nh9zfz.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jAGc3-0002xI-5G;;;mid=<87v9nh9zfz.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19gmt4QeYoR+3AHca+FGN8CxL45iobMdDI= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,XMNoVowels autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4958] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Bernd Edlinger X-Spam-Relay-Country: X-Spam-Timing: total 577 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 4.7 (0.8%), b_tie_ro: 3.8 (0.7%), parse: 1.59 (0.3%), extract_message_metadata: 16 (2.7%), get_uri_detail_list: 1.14 (0.2%), tests_pri_-1000: 26 (4.6%), tests_pri_-950: 1.69 (0.3%), tests_pri_-900: 1.48 (0.3%), tests_pri_-90: 36 (6.3%), check_bayes: 34 (6.0%), b_tokenize: 17 (3.0%), b_tok_get_all: 9 (1.5%), b_comp_prob: 3.0 (0.5%), b_tok_touch_all: 3.4 (0.6%), b_finish: 0.65 (0.1%), tests_pri_0: 475 (82.3%), check_dkim_signature: 0.56 (0.1%), check_dkim_adsp: 3.0 (0.5%), poll_dns_idle: 0.64 (0.1%), tests_pri_10: 2.4 (0.4%), tests_pri_500: 7 (1.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 1/2] exec: Properly mark the point of no return X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bernd Edlinger writes: > On 3/6/20 6:09 AM, Eric W. Biederman wrote: >> Bernd Edlinger writes: >> >>> On 3/5/20 10:15 PM, Eric W. Biederman wrote: >>>> >>>> Add a flag binfmt->unrecoverable to mark when execution has gotten to >>>> the point where it is impossible to return to userspace with the >>>> calling process unchanged. >>>> >>>> While techinically this state starts as soon as de_thread starts > > typo: s/techinically/technically/ >>>> killing threads, the only return path at that point is if there is a >>>> fatal signal pending. I have choosen instead to set unrecoverable > > I'm not good at english, is this chosen ? > Yes. Defintley worth fixing. Eric