Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 6 Mar 2020 10:46:29 -0800
From:   Benson Leung <bleung@google.com>
To:     Gwendal Grignou <gwendal@chromium.org>
Cc:     bleung@chromium.org, enric.balletbo@collabora.com,
        jflat@chromium.org, linux-kernel@vger.kernel.org,
        pmalani@chromium.org
Subject: Re: [PATCH] platform: chrome: Fix cros-usbpd-notify notifier
Message-ID: <20200306184629.GA253583@google.com>
References: <20200304232108.149553-1-gwendal@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm"
Content-Disposition: inline
In-Reply-To: <20200304232108.149553-1-gwendal@chromium.org>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Gwendal,

On Wed, Mar 04, 2020 at 03:21:08PM -0800, Gwendal Grignou wrote:
> cros-usbpd-notify notifier was returning NOTIFY_BAD when no host event
> was available in the MKBP message.
> But MKBP messages are used to transmit other information, so return
> NOTIFY_DONE instead, to allow other notifier to be called.
>=20
> Fixes: ec2daf6e33f9f ("platform: chrome: Add cros-usbpd-notify driver")
>=20
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

Queued for v5.7.

Thank you,
Benson

> ---
>  drivers/platform/chrome/cros_usbpd_notify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platfo=
rm/chrome/cros_usbpd_notify.c
> index 3851bbd6e9a39..ca2c0181a1dbf 100644
> --- a/drivers/platform/chrome/cros_usbpd_notify.c
> +++ b/drivers/platform/chrome/cros_usbpd_notify.c
> @@ -84,7 +84,7 @@ static int cros_usbpd_notify_plat(struct notifier_block=
 *nb,
>  	u32 host_event =3D cros_ec_get_host_event(ec_dev);
> =20
>  	if (!host_event)
> -		return NOTIFY_BAD;
> +		return NOTIFY_DONE;
> =20
>  	if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
>  		blocking_notifier_call_chain(&cros_usbpd_notifier_list,
> --=20
> 2.25.0.265.gbab2e86ba0-goog
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCXmKahQAKCRBzbaomhzOw
whwQAP4jCnzsupC6BWVC0gEzvODtsZAj6A5R19O/esCpw3QAaQD8DydhtsM7aqLZ
9uhlqN32iPL4n82hdYy+CKfNN6XwEAI=
=9AS2
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--