Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp7134123ybf; Fri, 6 Mar 2020 11:02:43 -0800 (PST) X-Google-Smtp-Source: ADFU+vtayvjSk5gcevLg7LgezuyCwuY/vZmzFwn8oElSC5dzQIVJsJZSJ4GS74c8Ee8LOZhrVWMx X-Received: by 2002:a9d:aa7:: with SMTP id 36mr3844110otq.52.1583521363314; Fri, 06 Mar 2020 11:02:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583521363; cv=none; d=google.com; s=arc-20160816; b=gSuQoBA4Nc0508B+O/6W/jaRxM9mEdJtg3/j/bQgdJUnYbQjoS8Q6/ykZ5j7J+kAFX +WLhIj3kSB4KTSV/OF6jcKsOB6/VYGLJYbOpTjc6lZuv0E7AWW4EZ0wrPb2e/dG/pxv1 SSYvv4F/+iLZIeWUnFqNgGjtMH024By09YsHePjsmYzZAaLrueAkDPFluGWz/qGXZC0I KNvYYCOZ/DERVP5vZ0tiELnzrThDpDZH6ELAEOqpfYxarK7db1Ae5FXgrUPa7RYM2NiY MI6MAUTeKve9dhdnCacv6yLwE+UfBf+QKleEsz54I6hkTA040NNjk6DzFCyia7a5ZJi5 xlrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=J/4TbhmhWHGXcwGzK0pmgTolsCmmer/5Ms5z8O9J4/Y=; b=C7uKUivrXaE9r+6YmiKKS2R+865uNMutWNtdY/ZsCgTZ7FTz+djMdUnSsi+MKH808y Ydka4mMmkEgri3flbV7NbmiBaafLih+Hy4LyKch1OPQQzBphJmUpQX/QTPstOwFrmDm5 fpE+uzEX0aWA9h5iH9auFAfKJfQXvzRMxR4He1a2KS4VWuMEaTTzrIS22uJ5YzWidSwn FcD2dQv8VgELGzYnTrJpPBI0KX1c6QgG7aXMBMeXXFFaB+cAT7CavJ0/8Czi4SofkyJJ 7iu9v/EIKYnQ2+17Np4weQvz4LN2uaxxP8nWVfN3Hw3XZmsmtmjSwttp7lV4qiPmP+X7 EZwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Sm5Xn3MM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w22si133545oih.103.2020.03.06.11.02.29; Fri, 06 Mar 2020 11:02:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Sm5Xn3MM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbgCFTCE (ORCPT + 99 others); Fri, 6 Mar 2020 14:02:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:36936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgCFTCE (ORCPT ); Fri, 6 Mar 2020 14:02:04 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FE2520637; Fri, 6 Mar 2020 19:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583521323; bh=d5l9TmIroeO1eBxz7Un/dH825zdsp6k7qVptxvn42TY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sm5Xn3MM059FvZ67/Nk160OCwFmuAK2CUpVbNFEVImqFNED8ayo4B4wujLAPnaC1t ntSVwEFq3WibKes8WkdjzgtdZW9GdMz21aHqh3ycmXWgbZjLpWxZd3NTtE32o++mrn KiQsHzUCwVAFm/IhT9/g18Jwios2z+QgzosWe6T0= Date: Fri, 6 Mar 2020 11:02:00 -0800 From: Jakub Kicinski To: Po Liu Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vinicius.gomes@intel.com, claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, alexandru.marginean@nxp.com, xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com, jerry.huang@nxp.com, leoyang.li@nxp.com, michael.chan@broadcom.com, vishal@chelsio.com, saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com, idosch@mellanox.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, john.hurley@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, pablo@netfilter.org, moshe@mellanox.com, ivan.khoronzhuk@linaro.org, m-karicheri2@ti.com, andre.guedes@linux.intel.com, jakub.kicinski@netronome.com Subject: Re: [RFC,net-next 3/9] net: schedule: add action gate offloading Message-ID: <20200306110200.5fc47ad7@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200306125608.11717-4-Po.Liu@nxp.com> References: <20200306125608.11717-1-Po.Liu@nxp.com> <20200306125608.11717-4-Po.Liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Mar 2020 20:56:01 +0800 Po Liu wrote: > +static int tcf_gate_get_entries(struct flow_action_entry *entry, > + const struct tc_action *act) > +{ > + entry->gate.entries = tcf_gate_get_list(act); > + > + if (!entry->gate.entries) > + return -EINVAL; > + > + entry->destructor = tcf_gate_entry_destructor; > + entry->destructor_priv = entry->gate.entries; What's this destructor stuff doing? I don't it being called. > + return 0; > +}