Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp7150511ybf; Fri, 6 Mar 2020 11:20:11 -0800 (PST) X-Google-Smtp-Source: ADFU+vuUsLzqRcqLf8csFVHtnrusWwcLbvj2RBg2bNG6ZhIg60Bt/gzMI72x3xl7Bn8m/SxP5cJY X-Received: by 2002:aca:4858:: with SMTP id v85mr3640172oia.51.1583522411342; Fri, 06 Mar 2020 11:20:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583522411; cv=none; d=google.com; s=arc-20160816; b=bC7m/Iuz64LM5H2cCcEvTTBPsP6O8Pta+pMzNMjMqqEbd5NKrvM6TAy9sQsEcGdhwA qbOjBZLOrUu2/ZTxEjMW80XyezJStFr5L0avodCQQzfH6NtzKZ0t3/pytrxXN9Ixuc3G +fbWkMWljPHqCrH+ZFOY1rhAl0S+URFEk/IMQMz2X8Z3YDlmRp/aCo5PKhzofIMfIU6M 1AEyQg4Gz8HOafl1tTouGIuMaDDXIKIebjK5KgO3PSjCI+mOiojFCUW9JkxL0QWAX4Uy WLscFeWprI17KuvafWZA3YSN6GiYXMzWAOykeueymYnKxXSF152qlWzpCxK+G2tM9ujD U9/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LScGVesqtkZaFAR3EU1Ov1dXKY8HwNoN04U19lNnJys=; b=O6+Sd1PB0Hd3H8Ih+CTWIs/lM6ANtcxW1pzndwP+PYpg9b2p9YxGyXHfbutqzLgXZ9 X19eXVEziuStILKc8P+e6BzuswZVfySzrk6V6QdayQFhwFiLhn123F9S8q5xr68dj38J HGSuIJQQBk4T1obsaP4aW/4mGO4Dl4w9XGzaIzHGdKlR8tSdRDQ60Poj8h71NJVsTlj/ 700vObcbdYgqhh686XavmZqKC5nklqU+4iNuGJsgQNxivfHPZJR+ofS74TtOmmNi69Ta X5nhOR27xbECZt/oYnCY0r3pEv/x73x5ekDSNpp49QA6Kzvx8B8KJOmQx1pLjC94nGsh NIcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AjSCejtw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si1750624oti.34.2020.03.06.11.19.59; Fri, 06 Mar 2020 11:20:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AjSCejtw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbgCFTTX (ORCPT + 99 others); Fri, 6 Mar 2020 14:19:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:40722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbgCFTTW (ORCPT ); Fri, 6 Mar 2020 14:19:22 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 017D520656; Fri, 6 Mar 2020 19:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583522362; bh=5AEkumCVq21wYUPEgUN2UKWndRwF68vU2Z4/miR0TWE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AjSCejtwdQmfnx5wwD4AedReUAFawuT45Q5LejthVrl3TQiLHy/1Etv9BdSClHmjI tkgRPapdJRAQdYoXkgcTaP+4758zuzWcS9XBYIdCp/fZkST3w1Dinh3i2aIHbYT8GW 9hCIb3WX8vcwjdI61CSEkPMEZr6LMcEcE53YTTp4= Date: Fri, 6 Mar 2020 11:19:19 -0800 From: Jakub Kicinski To: Po Liu Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vinicius.gomes@intel.com, claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, alexandru.marginean@nxp.com, xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com, jerry.huang@nxp.com, leoyang.li@nxp.com, michael.chan@broadcom.com, vishal@chelsio.com, saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com, idosch@mellanox.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, john.hurley@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, pablo@netfilter.org, moshe@mellanox.com, ivan.khoronzhuk@linaro.org, m-karicheri2@ti.com, andre.guedes@linux.intel.com, jakub.kicinski@netronome.com Subject: Re: [RFC,net-next 3/9] net: schedule: add action gate offloading Message-ID: <20200306111914.746d9bb3@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200306110200.5fc47ad7@kicinski-fedora-PC1C0HJN> References: <20200306125608.11717-1-Po.Liu@nxp.com> <20200306125608.11717-4-Po.Liu@nxp.com> <20200306110200.5fc47ad7@kicinski-fedora-PC1C0HJN> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Mar 2020 11:02:00 -0800 Jakub Kicinski wrote: > On Fri, 6 Mar 2020 20:56:01 +0800 Po Liu wrote: > > +static int tcf_gate_get_entries(struct flow_action_entry *entry, > > + const struct tc_action *act) > > +{ > > + entry->gate.entries = tcf_gate_get_list(act); > > + > > + if (!entry->gate.entries) > > + return -EINVAL; > > + > > + entry->destructor = tcf_gate_entry_destructor; > > + entry->destructor_priv = entry->gate.entries; > > What's this destructor stuff doing? I don't it being called. Ah, it's the action destructor, not something gate specific. Disregard.