Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp643735ybh; Sat, 7 Mar 2020 06:54:01 -0800 (PST) X-Google-Smtp-Source: ADFU+vvm89gKJSJDmRP9ixAnAXNVHIyhr/SM8KqkjJ8yTPldbcjAciCtvdyE7K+kHfh78/J5L0GX X-Received: by 2002:aca:3507:: with SMTP id c7mr2239333oia.147.1583592841817; Sat, 07 Mar 2020 06:54:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583592841; cv=none; d=google.com; s=arc-20160816; b=cCN2Os38lSA+TBSr4aCuz7jYa6jSHVTQMu9ma6TLgaUjZW2iov4BIuev4Hw5QWmUP4 QZxKgzVx0SCEqoem+HdE9Hqzko+GB+SZzDNe8J4lX3NSt9jgZt9C70aavjGxmPucLOTA TzCMmWMm7fq2W/iWhPoUWKK4UGOuVmVsRp8auXa8v/exsU/nEy2A+DW3KX/7QTO2L+8Z V7SKJw6LH3LVGxu38mNEmcJlkQ/3QXLCcou00LP+Ab3C2gu1mIfeLynEoAsrwXo9Hd9f 49JWxHzUufWq6JWeZCtFim67esewgQZ1BvzJCl2yXptWwqQPq2DRAgm/uyCsbwRQZRf8 v8wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=Y8Tdx3KfZc81a3rGHdnN+0ZYlULYSfpgdbKx5v+IVqE=; b=gXanvYz0sb38RtiuIlKWJM3FDKWds3UmXT66bHmZPXwt6GlkJTLdUDyjwD7ZmtU5XL 27S3czuErhR+6OjCKM2OH4V7FFd2hhGab7xBEy25L/qrAUCneTeguBHkQVvVjOuJh+FH kETjWlA88fHo8zjJN5L2WAtmrJzB5xe3GposHaH4iVjvV26o+0vBJ/EJK6wwGBWoABCU xdS/FzJmMFXIRQpxrhVHLeHx3PjCFig+CQ4n8A7zDnSSFmDBqTj3HvJWCGY3XifprPCh k+4ovs6HvqFXOoN3QoT+iwEYXltZ1Yyc4WxFwX9/3j43gQadCS24KcT4NuOxorMzGHcG SqdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n17si1254773oic.145.2020.03.07.06.53.48; Sat, 07 Mar 2020 06:54:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726399AbgCGOuc (ORCPT + 99 others); Sat, 7 Mar 2020 09:50:32 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47784 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgCGOub (ORCPT ); Sat, 7 Mar 2020 09:50:31 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8CA0B284F72; Sat, 7 Mar 2020 14:50:29 +0000 (GMT) Date: Sat, 7 Mar 2020 15:50:26 +0100 From: Boris Brezillon To: Cc: , , , kstewart@linuxfoundation.org, alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org, thor.thayer@linux.intel.com, jethro@fortanix.com, rfontana@redhat.com, miquel.raynal@bootlin.com, opensource@jilayne.com, richard@nod.at, michal.simek@xilinx.com, Ludovic.Desroches@microchip.com, joel@jms.id.au, nishkadg.linux@gmail.com, john.garry@huawei.com, vz@mleia.com, alexander.sverdlin@nokia.com, matthias.bgg@gmail.com, tglx@linutronix.de, swboyd@chromium.org, mika.westerberg@linux.intel.com, allison@lohutok.net, linux-arm-kernel@lists.infradead.org, andrew@aj.id.au, Nicolas.Ferre@microchip.com, linux-kernel@vger.kernel.org, dinguyen@kernel.org, michael@walle.cc, ludovic.barre@st.com, linux-mediatek@lists.infradead.org, info@metux.net Subject: Re: [PATCH 03/23] mtd: spi-nor: Move SFDP logic out of the core Message-ID: <20200307155026.20deb026@collabora.com> In-Reply-To: <20200302180730.1886678-4-tudor.ambarus@microchip.com> References: <20200302180730.1886678-1-tudor.ambarus@microchip.com> <20200302180730.1886678-4-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Mar 2020 18:07:46 +0000 wrote: > From: Tudor Ambarus > > It makes the core file a bit smaller and provides better separation > between the SFDP parsing and core logic. > > Keep the core.h and sfdp.h definitions private in drivers/mtd/spi-nor/. > Both expose just the definitions that are required by the core and > manufacturer drivers. None of the SPI NOR controller drivers should > include them. > > Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon