Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1345673ybh; Sun, 8 Mar 2020 01:18:38 -0800 (PST) X-Google-Smtp-Source: ADFU+vtnsn4knWnjiqq6R2HEOcdiR6e80Hp3YpO740SmJkYzQj+hmcEST+0yMUxZ9RIIsqOjZwid X-Received: by 2002:aca:d11:: with SMTP id 17mr7632841oin.38.1583659118807; Sun, 08 Mar 2020 01:18:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583659118; cv=none; d=google.com; s=arc-20160816; b=KCso1dMLbR1eOGdoVPrWsQa4k8zAa4elrvXFEnc/O6I7eXQFjBjMClKo3NvH1OGX0b 3YDQRvnzn3SAeDqhLqGTY2XLsPmYHZFuQy2WHxxUS43lpK9512wsl97fM223z+5yGpq3 x0r5hn8YGtnvU4NjIuP6FWgYoYeBZjkLDKrr4gl5lxO0kN/KrmFHYAKiAuq2gRHTrFgI Nh1PwTyw9mQC8qXUYp7vLrgaJrV+Jrw9KF/CZ67SLys2Ad9hBVuFlffLO4C/C6wVj0Y5 6MBWdYZt5K7E+j01CXG/aFoMQlFBR8EU18JspZbleawVDVYr9Kh+YB84FHXBknbbT7v7 RN+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=W9s4BIXPIa1gc/X8V7G/PBwtFy20UqDQLAwrho7Cyeo=; b=MDF2tEKPIkMmFIiOwFCt0S4EtGhq4JceKUqaiJY85pFV5GF5iqFvGx2bXqoonHBZKZ h6zfwA7mhyWquDJBls00kkXIVTN0lNQlqtvNrEkMQe0EsVAIrFHFA+67uO7byrB1pbWa gC62VhJS38TL+j10Uag7/+H5y2ymNcHnT+XruSJZ8OmOKkUdmRpy8zp/mBCz3WI7m07Z N9zHW1M9rlSB/eYXSk13qKgINHnI2LRSlWXJM7t+5/5tHdXeDJ1/Vhq7TNu/ZgCVIzzP bEVLiEae2C44OJY2N8c+63JOMEvAx4l7W9wdlFv+pBWvz9xCqSFoXOWYvT2NebWCO6f+ L4iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u24si4508491otk.287.2020.03.08.01.18.14; Sun, 08 Mar 2020 01:18:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726266AbgCHJRF (ORCPT + 99 others); Sun, 8 Mar 2020 05:17:05 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48155 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgCHJRF (ORCPT ); Sun, 8 Mar 2020 05:17:05 -0400 X-Originating-IP: 37.167.192.10 Received: from localhost (unknown [37.167.192.10]) (Authenticated sender: repk@triplefau.lt) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E877F1C0004; Sun, 8 Mar 2020 09:16:50 +0000 (UTC) Date: Sun, 8 Mar 2020 10:25:36 +0100 From: Remi Pommarel To: Jose Abreu Cc: Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-amlogic@lists.infradead.org" Subject: Re: [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used Message-ID: <20200308092536.GQ2248@voidbox> References: <20200306193036.18414-1-repk@triplefau.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 07, 2020 at 05:34:28PM +0000, Jose Abreu wrote: > From: Remi Pommarel > Date: Mar/06/2020, 19:30:36 (UTC+00:00) > > > void __iomem *ioaddr = hw->pcsr; > > + struct stmmac_priv *priv = netdev_priv(dev); > > u32 value = readl(ioaddr + GMAC_CONTROL); > > int mtu = dev->mtu; > > Please use reverse Christmas tree order and also provide a Fixes tag. Done in v2. Thanks, -- Remi