Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1472613ybh; Sun, 8 Mar 2020 05:14:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtOk5Chl0QOdFrP6mK8s1S1V+DDkIl2qHFLxjLVlySBBESfl4xX15riVD3lozEAMhrovLeb X-Received: by 2002:a05:6830:104a:: with SMTP id b10mr9683677otp.63.1583669696714; Sun, 08 Mar 2020 05:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583669696; cv=none; d=google.com; s=arc-20160816; b=OBCd7omMO7yNpSob6Rm2XYacSab+3J10MaG2RTBNATu3nL9unzcU9A5g2+jnMO0SkG 5GiPpGZisaUhT0XgLxj+eVs0DZy3y/Db45FbXQ5EzXk+GV+9ZoizzmdLgaHvxQNG4jEp NsGcEnBAf2wqdW6m5qkofnnnZydtdhamv6WB09rFoyvk0dokLsuBvrUrl+YVz5uJIP3E 2dRLIa2NYMbWUvOds02KwrJ/TqhPFuPtRkWQPKHIpeKf7/a9EZqNkIvH07tazS/x+wd4 Pad6AvVllHjiaGVl9WJ/m5nyh4HoSwYMwzJFqg5XHfxmHZNTPEBtFQQoIq9jfdoz5mbt iWNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=PEfo5U+KThJ+2dSa86wffu2yhkVnqBKQSrEF9vFo6wM=; b=heD00A8US9Kn9iPFI3zVEdkt8pgjDoxOgca+NfwTMwoP6Y9RMGvWGGidWIAu74TVtR Fq37gXsGhCu9wmrribOJgvbFoexAaiomHpmNwrvbxX+EwY34WyM9PWzMm/ZyrB6nd1i6 T8CupfoOiML2Z9Y5uOsbxKO4i+MOmQZ34Cfbe8DFVJP19q+w3xtumRrSYv+NDQMnYWEI 3dQFjtffoJ22NvFgIxioOQ55kr+DYpnbs6XHlNtUu3LGxMqCN9bfzMlPinsE2H7DmVSR S7pJDi4GLWYuG2hS8jXDjP9jPGANMfouvvFLOnHYFnDbDSw2MIWXKIS6Ptl3r8jUNDEG dJ6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZXcYM1Lv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2si2525382oie.56.2020.03.08.05.14.44; Sun, 08 Mar 2020 05:14:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZXcYM1Lv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726314AbgCHMMy (ORCPT + 99 others); Sun, 8 Mar 2020 08:12:54 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:44161 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726210AbgCHMMy (ORCPT ); Sun, 8 Mar 2020 08:12:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583669571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PEfo5U+KThJ+2dSa86wffu2yhkVnqBKQSrEF9vFo6wM=; b=ZXcYM1Lv33kZxrsbEYtnj67+YAhIKGT1oAuUxq8EAhPe9vw4n2kpJss3vT68CWF+1V0ChL grgot1gt2fEbVCzW2w6r4ax97Xj5Eqm7HiDHxF7EGCkntNRw/oFz9XP9YzsFsziI32pwjM X9NqQRb8FXK6eG2ffZGlP22RDoinqrY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-lpv-LdkRPHi1gEaHXMlsuA-1; Sun, 08 Mar 2020 08:12:47 -0400 X-MC-Unique: lpv-LdkRPHi1gEaHXMlsuA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D7DD800D5C; Sun, 8 Mar 2020 12:12:44 +0000 (UTC) Received: from [10.36.116.22] (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1ADF55C1C3; Sun, 8 Mar 2020 12:12:35 +0000 (UTC) Subject: Re: [PATCH RESEND v6 00/16] mm: Page fault enhancements To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Martin Cracauer , Linus Torvalds , Mike Rapoport , "Kirill A . Shutemov" , Johannes Weiner , "Dr . David Alan Gilbert" , Bobby Powers , Maya Gokhale , Jerome Glisse , Mike Kravetz , Matthew Wilcox , Marty McFadden , Mel Gorman , Hugh Dickins , Brian Geffon , Denis Plotnikov , Pavel Emelyanov References: <20200220155353.8676-1-peterx@redhat.com> <1eb7bdd4-348f-da87-47a1-0b022b70e918@redhat.com> <20200307214743.GA4206@xz-x1> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <6d8ed084-0740-cee1-663e-a78a2faee432@redhat.com> Date: Sun, 8 Mar 2020 13:12:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200307214743.GA4206@xz-x1> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] > Yes, IIUC the race can happen like this in your below test: >=20 > main thread uffd thread disgard thread > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > access page > uffd page fault > wait for page > UFFDIO_ZEROCOPY > put a page P there > MADV_DONTNEED on P > wakeup main thread > return from fault > page still missing > uffd page fault again > (without ALLOW_RETRY) > --> SIGBUS. Exactly! >> Can we please have a way to identify that this "feature" is available? >> I'd appreciate a new read-only UFFD_FEAT_ , so we can detect this from >> user space easily and use concurrent discards without crashing our app= lications. >=20 > I'm not sure how others think about it, but to me this still fells > into the bucket of "solving an existing problem" rather than a > feature. Also note that this should change the behavior for the page > fault logic in general, rather than an uffd-only change. So I'm also > not sure whether UFFD_FEAT_* suites here even if we want it. So, are we planning on backporting this to stable kernels? Imagine using this in QEMU/KVM to allow discards (e.g., balloon inflation) while postcopy is active . You certainly don't want random guest crashes. So either, we treat this as a fix (and backport) or as a change in behavior/feature. [...] >> >> 2. What will happen if I don't place a page on a pagefault, but only d= o a UFFDIO_WAKE? >> For now we were able to trigger a signal this way. >=20 > If I'm not mistaken the UFFDIO_WAKE will directly trigger the sigbus > even without the help of the MADV_DONTNEED race. Yes, that's the current way of injecting a SIGBUS instead of resolving the pagefault. And AFAIKs, you're changing that behavior. (I am not aware of a user, there could be use cases, but somehow it's strange to get a signal when accessing memory that is mapped READ|WRITE and also represented like this in e.g., /proc/$PID/maps). So IMHO, only the new behavior makes really sense. >=20 >> If the behavior is changed, can >> we make this configurable via a UFFD_FEAT? >=20 > I'll still think that could be an overkill, but I'll leave the > discussion to the experts. I'll be happy to hear what Andrea Et al. think. At least I really want to see the new behavior - and if it's not a fix, then I want some way to detect if a kernel has this new (fixed?) behavior. Thanks a lot for this work! --=20 Thanks, David / dhildenb