Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1544298ybh; Sun, 8 Mar 2020 07:00:41 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs3ki7HA0eidmQ0hd8cOe/qSQu+fDyP4HwzyUNj+rGlqaXD9pGrEOe7ym6ClCUQ6AHhgmF0 X-Received: by 2002:a9d:6310:: with SMTP id q16mr9090308otk.147.1583676040923; Sun, 08 Mar 2020 07:00:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583676040; cv=none; d=google.com; s=arc-20160816; b=hLetVP02qieLLZJvwy+2ZunLGTLrA6qxUNVJSNhZ/khMTFFAaB0PdBphDlf3tCs42o 0HKFTU+tI9LmvNzZZietfKllnL/9vToU6yHSjy2fK1//inHpeZk+KXi9rJJP1vthFL0o tlgbGTYZ+T13CdS2dQxT37n7A+vO7ShnF6UttbeI5TtnzZdONTuTAe7tzlcN/dMuBZvR rYO5hr+caAew9jEK8Ck5At+GrazfFXK05yEqX6TjtR35Re9qinWDEav7yoSXlC9q3/lh +T9/jrL8Mb7ar5x6dPp0HaLRzf2VrV+J5iDMTd+sdSVg7+NHKHlaFhD8SBuNkrJC7M5s dcBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=atM8LVEBHNH8aBah39/7yMxNKd0pisgzB5r3EHnqWsw=; b=Z+cue+t9nWcAaJjpjdqg8UmboQjjB+kZSU+p8YanmyjOKTIgJW8RUoG2BTlMtq2Fo+ TK5jJJVlzhG7ShJEmuz22POjAqS52y7YqLjaRHaR84M+B0NsftFQwVUEMqlnYw+oSfcT EG0VNHRQUpuuT4CzOwR9NU1/KZbREjE53ds/05iE6xbBWrAOGiaXT8+hrDd8pITX0C4p 5AYLgsYAX/rnSLaw/HHyhhq1Wx8cG+nYDLpVuNMjXzR6iyhfm6A/W2QR2Nf+v+fajji4 K+GZo1y82CvroFapwGX1S7Ptsd59kO3TE05gkI3fXqYycD5+JvUwENvy4j9JeC1JtcZn OjmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BXqNv88m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w134si610255oif.238.2020.03.08.07.00.21; Sun, 08 Mar 2020 07:00:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BXqNv88m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgCHN7g (ORCPT + 99 others); Sun, 8 Mar 2020 09:59:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:41138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726259AbgCHN7f (ORCPT ); Sun, 8 Mar 2020 09:59:35 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6ED2B206D7; Sun, 8 Mar 2020 13:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583675975; bh=0i5E1+7qOjaVYmSole07kk9HeR7FiaaKRB5ktGbe5Yg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BXqNv88mZHtri4Ucddv3jFGd4GBjlGH80ugf1qToiHrGx+fqNeeXR3WK3AcnuJhJg FlOkPEEUt7qjSOBlo+VLTAlja1dXtIA2hAtdH3k13gJerWGaWfYNYOtJbFN7nqZcoG yU10gC12p7X9We8Y61AmHLmd3K16OrJZ8M6S7ft4= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAwSr-00B2jV-Jn; Sun, 08 Mar 2020 13:59:33 +0000 Date: Sun, 8 Mar 2020 13:59:31 +0000 From: Marc Zyngier To: Atish Patra Cc: linux-kernel@vger.kernel.org, Anup Patel , Albert Ou , Anju T Sudhakar , Anup Patel , Borislav Petkov , "Eric W. Biederman" , James Morse , Jason Cooper , linux-riscv@lists.infradead.org, Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Steven Price , Thomas Gleixner , Ulf Hansson , Vincent Chen Subject: Re: [PATCH v3 1/2] irqchip/sifive-plic: Enable/Disable external interrupts upon cpu online/offline Message-ID: <20200308135931.331f9be4@why> In-Reply-To: <20200302231146.15530-2-atish.patra@wdc.com> References: <20200302231146.15530-1-atish.patra@wdc.com> <20200302231146.15530-2-atish.patra@wdc.com> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: atish.patra@wdc.com, linux-kernel@vger.kernel.org, anup@brainfault.org, aou@eecs.berkeley.edu, anju@linux.vnet.ibm.com, anup.patel@wdc.com, bp@suse.de, ebiederm@xmission.com, james.morse@arm.com, jason@lakedaemon.net, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, rafael.j.wysocki@intel.com, steven.price@arm.com, tglx@linutronix.de, ulf.hansson@linaro.org, vincent.chen@sifive.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Mar 2020 15:11:45 -0800 Atish Patra wrote: > Currently, PLIC threshold is only initialized once in the beginning. > However, threshold can be set to disabled if a CPU is marked offline with > CPU hotplug feature. This will not allow to change the irq affinity to a > CPU that just came online. > > Add PLIC specific CPU hotplug callbacks and enable the threshold when a CPU > comes online. Take this opportunity to move the external interrupt enable > code from trap init to PLIC driver as well. On cpu offline path, the driver > performs the exact opposite operations i.e. disable the interrupt and > the threshold. > > Signed-off-by: Atish Patra > Reviewed-by: Anup Patel Both patches queued for 5.7 (please add a cover letter when sending a patch series). Thanks, M. -- Jazz is not dead. It just smells funny...